Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add %config(noreplace) file attribute to builder #187

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Add %config(noreplace) file attribute to builder #187

merged 1 commit into from
Oct 21, 2023

Conversation

olivierlemasle
Copy link
Collaborator

@olivierlemasle olivierlemasle commented Oct 19, 2023 •
edited
Loading

Add method is_no_replace to FileOptionsBuilder, used to set the %config(noreplace) flag on a file

Closes #186

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

@olivierlemasle olivierlemasle marked this pull request as draft October 19, 2023 12:14
@olivierlemasle olivierlemasle force-pushed the conf_noreplace branch 2 times, most recently from a0dff53 to fa9623c Compare October 19, 2023 12:23
@olivierlemasle
Add %config(noreplace) file attribute to builder
7215f73 
Add method `is_no_replace` to `FileOptionsBuilder`, used to set
the `%config(noreplace)` flag on a file
@olivierlemasle olivierlemasle marked this pull request as ready for review October 19, 2023 12:25
dralley
dralley approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@dralley dralley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the current API, this is fine. I'm not sure I like the current API but that's another story :)

@dralley dralley merged commit 60d26da into master Oct 21, 2023
11 checks passed
@dralley dralley deleted the conf_noreplace branch October 21, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add %config(noreplace) file attribute
2 participants
@olivierlemasle @dralley