Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jobserver to prevent MSRV change #183

Closed
wants to merge 1 commit into from

Conversation

olivierlemasle
Copy link
Collaborator

With the release of its version 1.0.27, crate jobserver increased its MSRV to 1.66, even if was set in Cargo.toml only a few days after the release

Cf. rust-lang/jobserver-rs@9416b43

Without this dependency pinning, CI now fails (cf job https://github.com/rpm-rs/rpm/actions/runs/6531090162/job/17731629328 on PR #181 - the failure is unrelated to the PR)

📜 Checklist

  • Commits are cleanly separated and have useful messages
  • A changelog entry or entries has been added to CHANGELOG.md
  • Documentation is thorough
  • Test coverage is excellent and passes
  • Works when tests are run --all-features enabled

With the release of its version 1.0.27, crate `jobserver`
increased its MSRV to 1.66, even if was set in Cargo.toml
only a few days after the release

Cf. rust-lang/jobserver-rs@9416b43
@dralley dralley closed this Oct 16, 2023
@dralley
Copy link
Collaborator

dralley commented Oct 16, 2023

I'm just going to bump the MSRV.

#184

@olivierlemasle olivierlemasle deleted the pin-jobserver branch October 16, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants