Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag stable releases? #101

Open
gwerbin opened this issue Sep 30, 2021 · 3 comments
Open

Tag stable releases? #101

gwerbin opened this issue Sep 30, 2021 · 3 comments

Comments

@gwerbin
Copy link

gwerbin commented Sep 30, 2021

My Homebrew package for C2FFI was just rejected from Homebrew Core (Homebrew/homebrew-core#86127) because C2FFI does not have individual tagged releases. While there is a stable branch, individual versions are not tagged, and the Homebrew maintainers do not want to support packaging software with that kind of release program.

I will probably run into similar issues when trying to package C2FFI for other package managers and platforms. Would you consider tagging some "stable" releases within each branch, to facilitate packaging? This would make it a lot easier for people to use CFFI, especially given that it can be non-trivial to compile on MacOS.

@rpav
Copy link
Owner

rpav commented Oct 10, 2021

Sorry for the delay; yeah, that's not an issue at all. I'll try to get these tagged today. They'll be A.B.C.v where A.B.C is the LLVM release, and .v is the "c2ffi version" in that release. E.g., 11.0.0.0 will be the first release for c2ffi LLVM 11.0.0.

Also hopefully 13 support.

rpav added a commit that referenced this issue Oct 10, 2021
@attila-lendvai
Copy link
Contributor

@rpav did you mean to create the tag v11.1.0.0? or maybe v11.0.0.1?

i'd recommend a different tag pattern: v11.0.0-1 i.e. use a dash to differentiate between llvm's version, and c2ffi's version.

sidenote: this is what i was doing for the guix packaging before i learned about c2ffi tags (but it also includes the git hash: c2ffi-11.0.0-1.f502439).

and while we are at it, i would also only use the LLVM major version here and for the branch name.

@attila-lendvai
Copy link
Contributor

attila-lendvai commented Mar 16, 2022

FYI, c2ffi is now available in Guix, and uses the newly introduced git tags:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8c303758590e368fc6a67bfff8dd1721e70afd93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants