Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about "secure contexts" for offline mode #14

Open
rozbb opened this issue Aug 22, 2022 · 0 comments
Open

Add note about "secure contexts" for offline mode #14

rozbb opened this issue Aug 22, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@rozbb
Copy link
Owner

rozbb commented Aug 22, 2022

Currently, if you run scripts/prod.sh on your local network, offline mode will fail. The reason for this is because service workers can only be registered in "secure contexts" meaning localhost or http://..., and no more. This might be surprising for a developer trying out the server for the first time and finding that one of the core features doesn't work.

Make a prominent note somewhere saying that this is the expected behavior, and that you can only sample offline mode when you're localhost or running a real HTTPS server.

@rozbb rozbb added the documentation Improvements or additions to documentation label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant