Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme does not correspond to syntax highlight in text editors #1

Open
drybalka opened this issue Sep 23, 2024 · 2 comments
Open

Theme does not correspond to syntax highlight in text editors #1

drybalka opened this issue Sep 23, 2024 · 2 comments

Comments

@drybalka
Copy link

Hey, I know it is a bit of nitpicking at this point, but it kinda bothers me that the highlight colors used by bat do not correspond to the ones used in helix, neovim, sublime, or other text editors. For example, in the sublime config the built-ins are colored with "love" color, whereas here the "iris" color is used. It would be more consistent if the highlighting were the same across all applications. Would you be interested in such a fix?

@arrrgi
Copy link
Collaborator

arrrgi commented Sep 24, 2024

I think that would be a decision for @mvllow or @ThatOneCalculator to provide feedback on.

I would recommend providing some screenshots showing the differences and the proposed fix along with a PR and see what feedback you get.

@mvllow
Copy link
Member

mvllow commented Sep 24, 2024

I would personally consider Neovim to be a great reference for the "source of truth" but also it's semi-intentional to be relaxed and flexible enough so that anyone willing to donate their time porting Rosé Pine can do so with their own rendition. That being said, any PR that unifies colour usage between ports is always appreciated :)

Perhaps it would make contributing easier for some if we did have more specific documentation for applying our palette, even if simply a suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants