fixed missed installation of the .yaml parameters file #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the section "2.2 Loading parameters from YAML file", it was missing the necessity of installing the .yaml file. I tested what is written in C++ Signed-off-by: AlessandroMelone <[email protected]>
ahcorde
requested changes
Apr 11, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
…ge-Projects.rst added empty line before the code-block Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: AlessandroMelone <[email protected]>
…ge-Projects.rst added empty line before the code-block Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: AlessandroMelone <[email protected]>
removed empty line as suggested by ahcorde Signed-off-by: AlessandroMelone <[email protected]>
ahcorde
requested changes
Apr 12, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
…ge-Projects.rst Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: AlessandroMelone <[email protected]>
fujitatomoya
requested changes
Apr 13, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
…ge-Projects.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: AlessandroMelone <[email protected]>
…ge-Projects.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: AlessandroMelone <[email protected]>
clalancette
requested changes
Apr 15, 2024
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: AlessandroMelone <[email protected]>
source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
Outdated
Show resolved
Hide resolved
|
@AlessandroMelone thanks i have one comment, once it is resolved i will approve and check the html. |
|
@AlessandroMelone Friendly ping to deal with @fujitatomoya's latest comments. |
…ge-Projects.rst Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: AlessandroMelone <[email protected]>
|
@clalancette I accepted @fujitatomoya changes. Let me know if there is something else to do. Thank you |
|
@clalancette Friendly ping for review. |
|
So I believe that this was actually obsoleted by #4454 . So I'm going to go ahead and close this, but feel free to reopen if you disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the section "2.2 Loading parameters from YAML file", it was missing the necessity of installing the .yaml file. Missing that step, I was not generating the .yaml file in the /install folder, and therefore getting a runtime error.
I tested what is written in C++.
I was able to understand the solution to my problem thanks to this guide https://roboticsbackend.com/ros2-yaml-params/