Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is shm used in nodes connected in the same SOC #199

Closed
sgf201 opened this issue Jun 8, 2024 · 9 comments
Closed

Is shm used in nodes connected in the same SOC #199

sgf201 opened this issue Jun 8, 2024 · 9 comments

Comments

@sgf201
Copy link

sgf201 commented Jun 8, 2024

As I see,zenoh can use shm for msg ,Is shm used in rmw_zenoh?

@Yadunund
Copy link
Member

Yadunund commented Jun 8, 2024

Preliminary efforts were made to support SHM but certain memory leaks were discovered. Hence, SHM is disabled by default in the session config.

@sgf201
Copy link
Author

sgf201 commented Jun 8, 2024

as I see, loan api of ros2 is UNSUPPORTED now, will it supported with shm in roadmap?

@ruffsl
Copy link
Member

ruffsl commented Jun 8, 2024

Hence, SHM is disabled by default

@Yadunund , is there some context for that. From git blame of that config line, is this perhaps all of it?

@Yadunund
Copy link
Member

Hence, SHM is disabled by default

@Yadunund , is there some context for that. From git blame of that config line, is this perhaps all of it?

It's an issue in the Zenoh implementation. See eclipse-zenoh/zenoh#406.

My understanding is that Zettascale is working on a true-zero-copy alternative so we're likely going to wait for that to land and update our SHM implementation accordingly.

@JEnoch
Copy link
Contributor

JEnoch commented Jun 12, 2024

That's right, a new shared memory will be available very soon with Zenoh 1.0.0.
The development in Rust is already completed, and the C API has been merged to the dev/1.0.0 branch last week:
eclipse-zenoh/zenoh-c#405

@kikuyuta
Copy link

kikuyuta commented Jun 12, 2024

That's a great news!
According to my understanding, currently we can use zenoh-pico for poor capability chips e.g. ESP32.
Will zenoh 1.0.0, the Rust version with shared memory functionality, work on such poor chips? Or will zenoh-pico also have SHM functionality?

@JEnoch
Copy link
Contributor

JEnoch commented Jun 12, 2024

There is no plan for a Zenoh Rust for constrained devices, neither for SHM in zenoh-pico.
But the Zenoh team is always eager to learn about new use cases and to get suggestions of new features. 😃
Please, feel free to open a discussion here:
https://github.com/eclipse-zenoh/roadmap/discussions/categories/ideas-and-new-features

@kikuyuta
Copy link

@JEnoch Thank you for your reply.
Okay I will open a new discussion there, but later, because it is past midnight in Japan.

@sgf201
Copy link
Author

sgf201 commented Jun 13, 2024

as I see, loan api of ros2 is UNSUPPORTED now, will it supported with shm in roadmap?

can you give me a bref info about this?
@JEnoch

@sgf201 sgf201 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants