Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on rmw_dds_common #104

Closed
Yadunund opened this issue Feb 7, 2024 · 1 comment
Closed

Remove dependency on rmw_dds_common #104

Yadunund opened this issue Feb 7, 2024 · 1 comment
Assignees

Comments

@Yadunund
Copy link
Member

Yadunund commented Feb 7, 2024

This ticket is a follow up to the discuss #91 (comment)

#91 introduced a dependency on rmw_dds_common to reuse certain methods to check for qos compatibility. However, the zenoh protocol is generally more tolerable to QoS mismatches that rmw_dds_common might flag as incompatible. By relying on rmw_dds_common, we retain the incompatibility warnings despite transport delivering message payloads.

We should drop the rmw_dds_common dependency in the future and implement qos compatibility methods that better reflect the zenoh protocol.

@clalancette
Copy link
Collaborator

We did this in #234, so closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants