From 1e6bacdd99cdd47887b31f998aad7b9df27125c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Hern=C3=A1ndez=20Cordero?= Date: Fri, 20 Dec 2024 16:11:20 +0100 Subject: [PATCH] feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Alejandro Hernández Cordero --- zenoh_cpp_vendor/CMakeLists.txt | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/zenoh_cpp_vendor/CMakeLists.txt b/zenoh_cpp_vendor/CMakeLists.txt index 342038da..efaa5969 100644 --- a/zenoh_cpp_vendor/CMakeLists.txt +++ b/zenoh_cpp_vendor/CMakeLists.txt @@ -17,13 +17,6 @@ find_package(ament_cmake_vendor_package REQUIRED) # when expanded. set(ZENOHC_CARGO_FLAGS "--no-default-features$--features=shared-memory zenoh/transport_compression zenoh/transport_tcp zenoh/transport_tls") -# Set VCS_VERSION to include latest changes from zenoh-c to benefit from : -# - https://github.com/eclipse-zenoh/zenoh-c/pull/340 (fix build issue) -# - https://github.com/eclipse-zenoh/zenoh/pull/1021 (fix timeout issue with queries) -# - https://github.com/eclipse-zenoh/zenoh/pull/1022 (fix empty messages received if payload >btach size) -# - https://github.com/eclipse-zenoh/zenoh-c/pull/358 (fix debian packaging issue: https://github.com/jspricke/ros-deb-builder-action/issues/49) -# - https://github.com/eclipse-zenoh/zenoh/pull/1150 (fix deadlock issue https://github.com/ros2/rmw_zenoh/issues/182) -# - https://github.com/eclipse-zenoh/zenoh-c/pull/620 (fix ze_querying_subscriber_get API to query newly discovered publishers) ament_vendor(zenoh_c_vendor VCS_URL https://github.com/eclipse-zenoh/zenoh-c.git VCS_VERSION 57d5e4d31d9b38fef34d7bcad3d3e54869c4ce73 @@ -35,6 +28,10 @@ ament_vendor(zenoh_c_vendor ament_export_dependencies(zenohc) +# Set VCS_VERSION to include latest changes from zenoh-c to benefit from : +# - https://github.com/eclipse-zenoh/zenoh-cpp/pull/342 Fix include what you use +https://github.com/ros2/rmw_zenoh/issues/350 + ament_vendor(zenoh_cpp_vendor VCS_URL https://github.com/eclipse-zenoh/zenoh-cpp VCS_VERSION 964b64dc8b935a43147287199e7bb12da7b141e6