Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdformat_urdf is Disabled on the ROS buildfarm #36

Closed
Amronos opened this issue Oct 19, 2024 · 4 comments
Closed

sdformat_urdf is Disabled on the ROS buildfarm #36

Amronos opened this issue Oct 19, 2024 · 4 comments
Labels
question Further information is requested

Comments

@Amronos
Copy link

Amronos commented Oct 19, 2024

sdformat_urdf is disabled on the ROS buildfarm but is needed for the tests of ros-controls/ros2_control#1763, can it be enabled? More info can be found here.

@sloretz
Copy link
Contributor

sloretz commented Oct 28, 2024

sdformat_urdf is blacklisted on RHEL 9 because sdformat is not packaged for RHEL https://github.com/ros2/ros_buildfarm_config/blame/2e5343f0f35129f3c411bfb64a4e7a470e33c37c/jazzy/release-rhel-build.yaml#L56

I'd recommend either:

  • asking the sdformat maintainers what it would take to package it for RHEL https://github.com/gazebosim/sdformat/issues
  • asking the ros2_control maintainers if they're ok with using preprocessor macros and conditional dependencies to make sdformat support optional

I'll close this as not-planned until sdformat is available on RHEL.

@sloretz sloretz closed this as completed Oct 28, 2024
@sloretz sloretz added the question Further information is requested label Oct 28, 2024
@azeey
Copy link
Contributor

azeey commented Oct 28, 2024

Looks like gz_tools_vendor is not being built on RHEL (https://build.ros2.org/job/Jsrc_el9__gz_tools_vendor__rhel_9__source/). I'm going to look into it.

@azeey
Copy link
Contributor

azeey commented Nov 6, 2024

@sloretz sdformat is now available on RHEL for Jazzy and Rolling (see https://build.ros2.org/job/Jbin_rhel_el964__sdformat_vendor__rhel_9_x86_64__binary/ and https://build.ros2.org/job/Rbin_rhel_el964__sdformat_vendor__rhel_9_x86_64__binary/). Would you mind removing sdformat_urdf and sdformat_test_files from the black list for those releases?

@azeey
Copy link
Contributor

azeey commented Nov 6, 2024

I actually went ahead and created ros2/ros_buildfarm_config#312. Let me know if there's anything else that needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants