Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc conflicting versions #19295

Closed
tfoote opened this issue Oct 17, 2018 · 5 comments
Closed

grpc conflicting versions #19295

tfoote opened this issue Oct 17, 2018 · 5 comments
Assignees
Labels
melodic Issue/PR is for the ROS 1 Melodic distribution

Comments

@tfoote
Copy link
Member

tfoote commented Oct 17, 2018

grpc is released into kinetic and melodic but that is going to conflict with the system version.

This was flagged in #19184 and talking with the maintainer @BillWSY we talked about reducing the ROS packages to just provide the extras that are not in the upstream repositories: #19184 (comment)

For reference the Melodic PR: #19185

And an incoming rosdep key which will trigger the collision #19292

@BillWSY Would you be able to switch this to the stripped down version soon?

@tfoote tfoote self-assigned this Oct 17, 2018
@BillWSY
Copy link
Contributor

BillWSY commented Oct 17, 2018

I don't think I have enough bandwidth recently to update this package. Will we be able to provide two rosdep keys so that the users can choose between two versions for now?

@nuclearsandwich
Copy link
Member

@tfoote I acted as secondary approval and merged #19292 earlier before reviewing this issue. Should we revert that while we continue the discussion here?

@tfoote
Copy link
Member Author

tfoote commented Oct 17, 2018

The problem is that we cannot let users choose between the versions as it will just cause problems for downstream users.

If package A chooses implementation 1 and package B choose implementation 2. If a 3rdparty builds package C and depends on package A and package B it will be getting symbols from both conflicting versions but only one can be linked in so you'll get at best linking failures at worst non-deterministic runtime failures.

@nuclearsandwich Looking at it a little closer I think that the python implementation in #19292 doesn't appear to rely on the grpc library I think it has a pure implementation so that's actually slightly separated.

@BillWSY
Copy link
Contributor

BillWSY commented Oct 17, 2018

That makes sense. I think ROS had similar issues about OpenCV in indigo, but of course, this is much easier to solve than OpenCV.

The problem for me is that our robot is still running indigo, which makes supporting kinectic/melodic and testing them a lower priority to me. I will check with my colleagues @ruffsl and @MaidouPP to see if they are willing to work on this. Otherwise, I will try to get it done myself in a month or two.

@tfoote
Copy link
Member Author

tfoote commented Jan 2, 2020

I'm going to close this in favor of tracking it at: CogRob/catkin_grpc#35

@tfoote tfoote closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
melodic Issue/PR is for the ROS 1 Melodic distribution
Projects
None yet
Development

No branches or pull requests

3 participants