-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc conflicting versions #19295
Comments
I don't think I have enough bandwidth recently to update this package. Will we be able to provide two rosdep keys so that the users can choose between two versions for now? |
The problem is that we cannot let users choose between the versions as it will just cause problems for downstream users. If package A chooses implementation 1 and package B choose implementation 2. If a 3rdparty builds package C and depends on package A and package B it will be getting symbols from both conflicting versions but only one can be linked in so you'll get at best linking failures at worst non-deterministic runtime failures. @nuclearsandwich Looking at it a little closer I think that the python implementation in #19292 doesn't appear to rely on the grpc library I think it has a pure implementation so that's actually slightly separated. |
That makes sense. I think ROS had similar issues about OpenCV in indigo, but of course, this is much easier to solve than OpenCV. The problem for me is that our robot is still running indigo, which makes supporting kinectic/melodic and testing them a lower priority to me. I will check with my colleagues @ruffsl and @MaidouPP to see if they are willing to work on this. Otherwise, I will try to get it done myself in a month or two. |
I'm going to close this in favor of tracking it at: CogRob/catkin_grpc#35 |
grpc is released into kinetic and melodic but that is going to conflict with the system version.
This was flagged in #19184 and talking with the maintainer @BillWSY we talked about reducing the ROS packages to just provide the extras that are not in the upstream repositories: #19184 (comment)
For reference the Melodic PR: #19185
And an incoming rosdep key which will trigger the collision #19292
@BillWSY Would you be able to switch this to the stripped down version soon?
The text was updated successfully, but these errors were encountered: