Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Quaternion is invalid #181

Open
Vini-002 opened this issue Aug 3, 2022 · 2 comments
Open

Default Quaternion is invalid #181

Vini-002 opened this issue Aug 3, 2022 · 2 comments

Comments

@Vini-002
Copy link

Vini-002 commented Aug 3, 2022

I just tried to use the default quaternion - Quaternion() - in a situation where I don't have rotation information and got an error that this quaternion is invalid. The solution was really simple, just added w = 1 as a keyword parameter. I would suggest that to be the default quaternion.

I'm new to open source... but I imagine I should fork, change that and submit a pull request, right?

@Vini-002
Copy link
Author

Vini-002 commented Aug 3, 2022

I've just discovered the code I was looking at was automatically generated by genpy and don't know if it is possible to modify it.

@peci1
Copy link

peci1 commented Apr 9, 2023

I don't think such PR would go through. Zero-initialized fields are a pretty standardized thing in ROS messages and nobody should expect anything else. It's the same with colors: if you set just RGB, and forget to set alpha to 1.0, your markers do not show up. The takeaway is - you always need to know and understand the data you are sending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants