Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Iron CI and other fixes #27

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ros2-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
matrix:
include:
- docker-image: "ubuntu:22.04"
ros-distro: "rolling"
ros-distro: "iron"
container:
image: ${{ matrix.docker-image }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ This metapackage contains the most common plugins for pointcloud compression usi

Currently provided are:

- [draco_point_cloud_transport](https://github.com/ros-perception/point_cloud_transport_plugins/tree/rolling/draco_point_cloud_transport) - A library using Google Draco to compress the pointclouds.
- [draco_point_cloud_transport](https://github.com/ros-perception/point_cloud_transport_plugins/tree/iron/draco_point_cloud_transport) - A library using Google Draco to compress the pointclouds.

- [zlib_point_cloud_transport](https://github.com/ros-perception/point_cloud_transport_plugins/tree/rolling/zlib_point_cloud_transport) - A libraory using zlib to compress the pointclouds.
- [zlib_point_cloud_transport](https://github.com/ros-perception/point_cloud_transport_plugins/tree/iron/zlib_point_cloud_transport) - A libraory using zlib to compress the pointclouds.

- [zstd_point_cloud_transport](https://github.com/ros-perception/point_cloud_transport_plugins/tree/master/zstd_point_cloud_transport) - A library using ZSTD to compress the pointclouds.

Expand Down
16 changes: 8 additions & 8 deletions plugin_template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This is the spiritual successor to: https://github.com/paplhjak/templateplugin_p
## 1) Plugin naming
Each plugin needs its own name. It should be short and descriptive.

For example: [draco_point_cloud_transport](https://github.com/ros-perception/point_cloud_transport_plugins/tree/rolling/draco_point_cloud_transport) is a plugin which uses Google [Draco](https://github.com/google/draco) compression, therefore the name **draco**.
For example: [draco_point_cloud_transport](https://github.com/ros-perception/point_cloud_transport_plugins/tree/iron/draco_point_cloud_transport) is a plugin which uses Google [Draco](https://github.com/google/draco) compression, therefore the name **draco**.

For demonstrative purposes, the plugin which we will be going through in this tutorial has used the name **template**. And we will be modifying the template to make our own plugin named **goblin**.

Expand Down Expand Up @@ -53,7 +53,7 @@ Although making your own compressed message type is an option, please check `poi
CustomMessage -> CompressedPointCloud2
```

If you do need a custom message, let's assume it is called **GobMessage**. See here if you are not familiar with defining a custom ROS2 message: https://docs.ros.org/en/rolling/index.html.
If you do need a custom message, let's assume it is called **GobMessage**. See here if you are not familiar with defining a custom ROS2 message: https://docs.ros.org/en/iron/index.html.
Once you have defined your **GobMessage**, go through the following files (do not forget to check the #include's):

1. *goblin_publisher.h*
Expand Down Expand Up @@ -83,15 +83,15 @@ The *decodeTyped* function takes in our plugin's message format, decompresses th

## 7) Description of Plugin

Before we distribute our plugin, it is important that we fill in all the necessary information about it.
Before we distribute our plugin, it is important that we fill in all the necessary information about it.

In `goblin_plugins.xml`, make sure to provide a brief description of both the publisher and the subscriber our plugin uses.

Then fill out the package.xml. If you are unfamiliar with how to do this, see here please: https://docs.ros.org/en/rolling/Tutorials/Beginner-Client-Libraries/Creating-Your-First-ROS2-Package.html#customize-package-xml.
Then fill out the package.xml. If you are unfamiliar with how to do this, see here please: https://docs.ros.org/en/iron/Tutorials/Beginner-Client-Libraries/Creating-Your-First-ROS2-Package.html#customize-package-xml.

## 8) Build time!

At this point your plugin should be able to succesfully compile, build, and be recognized by [point_cloud_transport](https://github.com/ros-perception/point_cloud_transport).
At this point your plugin should be able to succesfully compile, build, and be recognized by [point_cloud_transport](https://github.com/ros-perception/point_cloud_transport).

First, delete the COLCON_IGNORE file in `globlin_point_cloud_transport` (otherwise your package will be ignored).

Expand All @@ -114,10 +114,10 @@ The output should look something like this.
```
"point_cloud_transport/goblin"
- Provided by package: goblin_point_cloud_transport
- Publisher:
- Publisher:
This plugin publishes a CompressedPointCloud2 using the awesome power of turtles.
- Subscriber:

- Subscriber:
This plugin decompresses a CompressedPointCloud2 topic, also using turtles.
```

Expand Down
2 changes: 1 addition & 1 deletion plugin_template/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<maintainer email="[email protected]">YourNameHere</maintainer>
<license>BSD</license>

<url type="repository">https://github.com/rolling/point_cloud_transport_plugins</url>
<url type="repository">https://github.com/iron/point_cloud_transport_plugins</url>

<buildtool_depend>ament_cmake</buildtool_depend>

Expand Down
2 changes: 1 addition & 1 deletion point_cloud_transport.repos
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ repositories:
point_cloud_transport:
type: git
url: https://github.com/john-maidbot/point_cloud_transport
version: rolling
version: iron
Loading