image_proc::CropDecimateNode: parameter handle #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhubii
commented
May 2, 2024
There was a problem hiding this comment.
2 general questions:
- Which formatting?
- Note to self: https://github.com/uncrustify/uncrustify (cause for failed build?)
- Where are uncrustify configurations?
- Are tests wanted?
| rcl_interfaces::msg::SetParametersResult result; | ||
| result.successful = true; | ||
| for (const auto & param : parameters) { | ||
| if (param.get_name() == "offset_x") { |
There was a problem hiding this comment.
- Should other parameters be handled as well?
- Are additional checks on set desired?
- Introduce parameter name as members?
There was a problem hiding this comment.
you can also add decimation_x_, decimation_y_ and target_frame_id_
ahcorde
reviewed
May 17, 2024
There was a problem hiding this comment.
uncrustify is failing https://build.ros2.org/job/Rpr__image_pipeline__ubuntu_noble_amd64/6/testReport/junit/image_proc/uncrustify/src_crop_decimate_cpp/
you can fix this with:
ament_uncrustify --reformat <path to file>| rcl_interfaces::msg::SetParametersResult result; | ||
| result.successful = true; | ||
| for (const auto & param : parameters) { | ||
| if (param.get_name() == "offset_x") { |
There was a problem hiding this comment.
you can also add decimation_x_, decimation_y_ and target_frame_id_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #967.
Thank you @ahcorde for kindly offering review of this PR. I'll review my main questions shortly.