Copying the entire openni_launch package from https://github.com/ros-drivers/openni_launch. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…drivers/openni_launch. See ros-drivers/openni_launch#30 (comment) for the decision for this change. Preserving commit history was attempted (using the method in http://www.pixelite.co.nz/article/extracting-file-folder-from-git-repository-with-full-git-history), but didn't seem to easily work due to ros-drivers/openni_launch#4 that resurrects the change made previously in a few files and somehow `git am` command stops. So unfortunately, instead of spending more time on trying to save the commit history, I suggest to move forward.
|
ROS pre-release test, which checks downstream packages, failed for Indigo here and Kinetic (at the bottom of the log) for the same following key error in some of the downstream package(s). This looks irrelevant to the change in this PR. |
|
Buildfarm test failed for the same reason as #56 (comment), which we ignored then. So do I this time as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ros-drivers/openni_launch#30 (comment) for the decision for this change.
Preserving commit history was attempted (using the method in this article), but didn't seem to easily work due to ros-drivers/openni_launch#4 that resurrects the change made previously in a few files and somehow
git amcommand stops. So unfortunately, instead of spending more time on trying to save the commit history, I suggest to move forward.This addresses #53.