Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch pluginlib exceptions #175

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Aug 21, 2023

Related with this PR in gazebo_ros2_control ros-controls/gazebo_ros2_control#229

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Aug 21, 2023
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the format issue, this LGTM!

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde merged commit a88a19a into master Aug 21, 2023
@ahcorde ahcorde deleted the ahcorde/rolling/catch_pluginlib_exceptions branch August 21, 2023 08:07
@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 21, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 21, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit a88a19a)

# Conflicts:
#	ign_ros2_control/src/ign_ros2_control_plugin.cpp
ahcorde pushed a commit that referenced this pull request Aug 21, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Aug 23, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants