Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_dpird_summaries() is not returning lat/lon values #42

Open
adamhsparks opened this issue Oct 25, 2023 · 2 comments
Open

get_dpird_summaries() is not returning lat/lon values #42

adamhsparks opened this issue Oct 25, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@adamhsparks
Copy link
Member

adamhsparks commented Oct 25, 2023

weatherOz::get_dpird_summaries(station_code = "BI", start_date = "20171028", 
    end_date = "20221028", api_key = Sys.getenv("DPIRD_API_KEY"), 
    interval = "yearly", values = "wind")
#>     station_code station_name year wind_avg_speed wind_height
#>  1:           BI        Binnu 2017          13.24           3
#>  2:           BI        Binnu 2017          18.38          10
#>  3:           BI        Binnu 2018          13.51           3
#>  4:           BI        Binnu 2018          18.99          10
#>  5:           BI        Binnu 2019          13.72           3
#>  6:           BI        Binnu 2019          19.00          10
#>  7:           BI        Binnu 2020          14.09           3
#>  8:           BI        Binnu 2020          19.08          10
#>  9:           BI        Binnu 2021          14.92           3
#> 10:           BI        Binnu 2021          19.38          10
#> 11:           BI        Binnu 2022          15.52           3
#> 12:           BI        Binnu 2022          19.75          10
#>     wind_max_direction_compass_point wind_max_direction_degrees wind_max_speed
#>  1:                              NNW                        338         147.60
#>  2:                               SE                        129          81.90
#>  3:                              SSE                        157          71.24
#>  4:                               SE                        130         149.33
#>  5:                              ESE                        116          72.94
#>  6:                                N                        353         159.23
#>  7:                              NNE                         33          77.11
#>  8:                              WNW                        285          76.61
#>  9:                              WSW                        256          88.85
#> 10:                              WSW                        247          84.49
#> 11:                              SSW                        208          98.10
#> 12:                                E                         83          76.50
#>           wind_max_time
#>  1: 2021-04-11 20:30:00
#>  2: 2018-02-17 00:00:00
#>  3: 2017-02-18 16:04:00
#>  4: 2005-08-20 00:00:00
#>  5: 2022-02-04 15:19:00
#>  6: 2016-03-21 00:00:00
#>  7: 2020-05-24 09:56:00
#>  8: 2023-05-22 00:00:00
#>  9: 2018-08-29 09:36:00
#> 10: 2001-08-18 00:00:00
#> 11: 2019-03-27 14:16:00
#> 12: 2012-11-19 00:00:00

Created on 2023-10-25 with reprex v2.0.2

No longitude or latitude cols as the docs suggest.

@adamhsparks adamhsparks self-assigned this Oct 25, 2023
@adamhsparks adamhsparks added the bug Something isn't working label Oct 25, 2023
@adamhsparks
Copy link
Member Author

At some point in the future, the Weather 2.0 API will be able to optionally return the latitude and longitude values along with the station_code and station_name. But for now, since it doesn't, we will implement two calls. One to the metadata and one for the weather data and join them.

Once the API is updated we can close this issue.

@adamhsparks
Copy link
Member Author

This is fixed (for now) with 5f074f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant