Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMVA] Enforce supported version of TensorFlow #15275

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

vepadulano
Copy link
Member

We do not support Tensorflow >2.15 since Keras 3.x brings several breaking changes keras-team/keras#18467

We do not support Tensorflow >2.15 since Keras 3.x brings several breaking changes keras-team/keras#18467
@vepadulano vepadulano requested a review from lmoneta April 19, 2024 13:11
@vepadulano vepadulano requested a review from dpiparo as a code owner April 19, 2024 13:11
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

An important link is also the release notes of TensorFlow, which indicate that there was a switch from Keras 2 to Keras 3:
https://blog.tensorflow.org/2024/03/whats-new-in-tensorflow-216.html

@guitargeek
Copy link
Contributor

I see these build failures on alma9:

  Scanning dependencies of target G__TMVAUtils
  Consolidate compiler generated dependencies of target G__TMVAUtils
  [ 98%] Building CXX object tmva/tmva/CMakeFiles/G__TMVAUtils.dir/G__TMVAUtils.cxx.o
  [ 98%] Linking CXX executable TestRModelParserPyTorch
  /usr/bin/ld: cannot find -lblas

But these problems are not related to this PR, which only changes the requirements.txt.

Copy link

Test Results

    10 files      10 suites   2d 1h 26m 13s ⏱️
 2 628 tests  2 583 ✅ 0 💤  45 ❌
24 638 runs  24 506 ✅ 2 💤 130 ❌

For more details on these failures, see this check.

Results for commit e1166c0.

@guitargeek
Copy link
Contributor

Merging now, so I can make a bulk backport of the recent TMVA build fixes to the other branches

@guitargeek guitargeek merged commit e30dc62 into root-project:master Apr 19, 2024
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants