Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticker search displays incorrect result, but places correct symbol. #29

Open
txcrew opened this issue May 20, 2020 · 4 comments
Open

Comments

@txcrew
Copy link

txcrew commented May 20, 2020

Found a potential bug that reveals itself when searching for a specific sticker, but displays the first sticker in a set of results.

In the below example, the user is searching disabled which should surface the result, item disabled. Instead, it shows the first result in the row of stickers (in the case of the below example it's the sticker labeled logo). However, when the user drags the sticker into the document, it's the correct symbol.

screen

These are the tags in the file

!StickerLibrary
title: My library

!StickerSection @Section1
title: First section
@romannurik
Copy link
Owner

Whoa weird. Does it persist if you clear your library cache? If it does, I'd love if you could privately share the file with me so I could test.

@txcrew
Copy link
Author

txcrew commented May 22, 2020

Yeah, unfortunately, it still does it even after I disabled all other plugins, cleared the library cache, and relaunched Sketch. Here's a library it happens on (a little different than the example), just search red, green, or blue in the sticker sheet (and also try clearing the text string and typing a new one): https://send.firefox.com/download/e6da5701f12d9a0b/#qo2QIFsstZ3bVQZ-nzBsbg

@txcrew
Copy link
Author

txcrew commented May 28, 2020

After further tests, the weird overlap only seems to happen in a stickerSection without a sub-section. Not sure if that will help pinpoint the issue, but I figured I'd share the finding. Here's hoping! :)

@romannurik
Copy link
Owner

Thank you so much for digging deeper! I'll take a look at a fix when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants