Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minor modes to exclusion list? #63

Open
mattfidler opened this issue Dec 18, 2015 · 2 comments
Open

Add minor modes to exclusion list? #63

mattfidler opened this issue Dec 18, 2015 · 2 comments

Comments

@mattfidler
Copy link

Currently, golden-ratio excludes based on major modes. However, excluding based on minor-modes may also be useful. For example minimap-mode shouldn't allow golden-ratio to modify. Of course this can be accomplished with golden-ratio-inhibit-functions, or even golden-ratio-exclude-buffer-names. However, I think that it may also be useful to add a customizable variable for minor-modes.

@mattfidler
Copy link
Author

I actually can't figure out what to toggle to make the minimap work correctly.

I have tried

(defun ergoemacs-golden-ratio-exclude-minimap-p ()
      (memq this-command '(minimap-toggle)))
    (setq golden-ratio-inhibit-functions '(ergoemacs-golden-ratio-exclude-minimap-p))
(add-to-list 'golden-ratio-exclude-buffer-regexp "^\\*MINIMAP\\*")

But it doesn't quite work correctly.

@wictory
Copy link
Collaborator

wictory commented Dec 17, 2019

It seems that simply inhibiting minimap-mode does not solve every issue between golden-ratio-mode and minimap-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@mattfidler @wictory and others