fix(dynamic-import-vars): normalize paths at runtime #1794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearfriend
commented
Oct 18, 2024
| @@ -234,25 +297,3 @@ Generated by [AVA](https://avajs.dev). | |||
| ␊ | |||
| export { importModule };␊ | |||
| ` | |||
|
|
|||
| ## no files in dir | |||
There was a problem hiding this comment.
Do I just add this back manually?
bearfriend
changed the title
bearfriend
changed the title
bearfriend
force-pushed
the
dgleckler/dynamic-import-vars-normalize-paths
branch
2 times, most recently
from
e6359f3 to
16b1fd7
Compare
shellscape
changed the title
|
Really appreciate the work on this. However, there are still some failing tests and this ends up injecting more code into a bundle on the resulting end. I thought on this for a while this weekend, and we're going to revert this plugin back to the previous version's state, since the only benefit to the change was fewer dependencies, and the juice is just not worth the squeeze. |
|
I think the tests got into an odd state from some force pushes, and should have been passing otherwise. Not sure, though. Regardless, the changes were weirder than I thought they'd be. I support reverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
dynamic-import-varsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: #1791
Description
Fixes #1791 by normalizing paths at runtime to match the glob results. I decided again using a port of node's
posix.normalizeto both avoid forcing dependencies on consumers and also because the existing restrictions of the plugin mean it was (relatively) easy to transform the paths into how we need them.