From 2b9a56d6272d010f4cf010aa77d0af1035f78cd8 Mon Sep 17 00:00:00 2001
From: Simon Haugen <smn.hgn@gmail.com>
Date: Sun, 21 Apr 2024 20:27:54 +0200
Subject: [PATCH] fix(replace): fix replace for ternary operators

---
 packages/replace/src/index.js                   |   5 +++--
 .../fixtures/form/ternary-operator/_config.js   |   9 +++++++++
 .../fixtures/form/ternary-operator/input.js     |   3 +++
 .../fixtures/form/ternary-operator/output.js    |   3 +++
 packages/replace/test/snapshots/form.js.md      |   8 ++++++++
 packages/replace/test/snapshots/form.js.snap    | Bin 733 -> 801 bytes
 6 files changed, 26 insertions(+), 2 deletions(-)
 create mode 100755 packages/replace/test/fixtures/form/ternary-operator/_config.js
 create mode 100644 packages/replace/test/fixtures/form/ternary-operator/input.js
 create mode 100644 packages/replace/test/fixtures/form/ternary-operator/output.js

diff --git a/packages/replace/src/index.js b/packages/replace/src/index.js
index acfb91990..cdbe6419a 100755
--- a/packages/replace/src/index.js
+++ b/packages/replace/src/index.js
@@ -74,9 +74,10 @@ export default function replace(options = {}) {
   if (objectGuards) expandTypeofReplacements(replacements);
   const functionValues = mapToFunctions(replacements);
   const keys = Object.keys(functionValues).sort(longest).map(escape);
-  const lookahead = preventAssignment ? '(?!\\s*(=[^=]|:[^:]))' : '';
+  const lookbehind = preventAssignment ? '(?<!\\b(?:const|let|var)\\s*)' : '';
+  const lookahead = preventAssignment ? '(?!\\s*=[^=])' : '';
   const pattern = new RegExp(
-    `${delimiters[0]}(${keys.join('|')})${delimiters[1]}${lookahead}`,
+    `${lookbehind}${delimiters[0]}(${keys.join('|')})${delimiters[1]}${lookahead}`,
     'g'
   );
 
diff --git a/packages/replace/test/fixtures/form/ternary-operator/_config.js b/packages/replace/test/fixtures/form/ternary-operator/_config.js
new file mode 100755
index 000000000..1dd1ac890
--- /dev/null
+++ b/packages/replace/test/fixtures/form/ternary-operator/_config.js
@@ -0,0 +1,9 @@
+module.exports = {
+  description: "replaces value inside ternary operators",
+  options: {
+    condition: 'first',
+    exprIfTrue: 'second',
+    exprIfFalse: 'third',
+    preventAssignment: true
+  }
+};
diff --git a/packages/replace/test/fixtures/form/ternary-operator/input.js b/packages/replace/test/fixtures/form/ternary-operator/input.js
new file mode 100644
index 000000000..e3a14e873
--- /dev/null
+++ b/packages/replace/test/fixtures/form/ternary-operator/input.js
@@ -0,0 +1,3 @@
+/* eslint-disable */
+condition ? exprIfTrue : exprIfFalse;
+console.log(condition, exprIfTrue, exprIfFalse);
\ No newline at end of file
diff --git a/packages/replace/test/fixtures/form/ternary-operator/output.js b/packages/replace/test/fixtures/form/ternary-operator/output.js
new file mode 100644
index 000000000..81dd1102b
--- /dev/null
+++ b/packages/replace/test/fixtures/form/ternary-operator/output.js
@@ -0,0 +1,3 @@
+/* eslint-disable */
+first ? second : third;
+console.log(first, second, third);
\ No newline at end of file
diff --git a/packages/replace/test/snapshots/form.js.md b/packages/replace/test/snapshots/form.js.md
index cc254b516..04ba72de9 100644
--- a/packages/replace/test/snapshots/form.js.md
+++ b/packages/replace/test/snapshots/form.js.md
@@ -87,6 +87,14 @@ Generated by [AVA](https://avajs.dev).
       replaced.doSomething()␊
     \`);`
 
+## ternary-operator: replaces value inside ternary operators
+
+> Snapshot 1
+
+    `/* eslint-disable */␊
+    first ? second : third;␊
+    console.log(first, second, third);`
+
 ## typescript-declare: doesn't replace lvalue in typescript declare
 
 > Snapshot 1
diff --git a/packages/replace/test/snapshots/form.js.snap b/packages/replace/test/snapshots/form.js.snap
index e907e7442b28b234108504ee7b6f80061beeb5d4..242f1c08c07fa821ff2f54c6fba036f3c48d578e 100644
GIT binary patch
literal 801
zcmV++1K#{WRzV<BZeeh9Xm4~Nb~6eC07UZ5hGegS$5^YBh|gd>t8ox&7vkUB2f;Gn
zhm+Ijz#oeU00000000AxmCtX}Fcil(A%v70S2*xiX-hjTX@`(t=~{k>0YVH8Xc8Qd
z=Grf<H`k8*oOTo9z@2|${G}*q(j;V?)|37Gb>7Eczvo`X6J_{0{rQVdI)xVlMkJ?t
zj@m^a43hR8SWFb-2x`GpiXb&qDoL6pG&7EVUkSk+`_{X+@n9qSZQkE_xcNA-h9gmk
zdJ(=odUNs~M&LUn=MT%IPXsDCmkupOU?zlifdo~so#SI8$00YGjKWZvY4_BF5?FWu
zhudJRoJ!5q_BfxHQ`jDRr@b}AV9p$$1q)^+n<%6R@&FRd4LP6$xr`-;wV+KkXi#<P
zRQ?1VgGF{2qhUWBgag0I{k%AIkf?Mjbzl-Fji%KNfHu_?tOQU9+6cUXaB_<=mAxJS
znbdNevt&I!&c{-7l?wC#@M1NpITjUH8}J$O^9VjLEff+IVQ`lT!Zc-8P*yWV?yP98
z0jCBy${4!YeiN@hw>27ppK5`z)F^z|*?~@CjYxUsMF&RNdKK_{@Y4fmTta<y==~}W
zvQ?l3+PIn2)2L+4z0V?T-bI6V)=0xBkk0Q7q2C82CAABLq^xKHB{h0=adF6{)WR%7
zVR)JubmQI@GC3>tlxoODq>cQkfjq8LJbQXK+K!o=A$Ogs2o7r38pNs2-Hm`LWtLRG
zb8rSG2n<S58?f5|e1sQ?u?_^rEL9FVQYWbk&#1Fb-p{*|sesRzWqkF3P?}`>2#Q6h
z7TYP`HB!FF&g#Hugc0oD=t#p7qp@;hR07psw8D!j1WV~=cfy-C@V?*D&fRj{%UXE#
zX?2-3ZZWCJLt(y}Ip&q!?bTcQz@gR5UIr#X%bc;bx+))kk^-U7L8-fj{YQiSOMmx2
zFJZUu#nO_4mq5sk77&4(Nh^j8gLBPZA=z6gD&kjJ0};0}ae+Xtn8n-vxGFUi>Nfbe
f0X`^nu&RyEuaA$SqQ@GTYybZNKRZ>uR0jY6<cfDP

literal 733
zcmV<30wVoERzV<BZeeh9Xm4~Nb~6eC0H+_}<Y^s}k`_OY)BZiMCnOddf~_}I!2^)2
zGqRK=p&yF~00000000Axl~HfgFc8N#A%wIyUg3dTq%G}3vJN2u-8uncfDq#aO@g<%
z&ZYI{+ELEwHX$B(=2MJMik&)5tgvZ)I-k$E-~I3G-sDrM`33#?i$)lUS0hFwW@>@T
zj3LuVDmGAJAsI)IOC~D>p`eWtq*y_7ZRqz+mNCP=4<Bqi+Hk+khZ~PKpBAO&NR*;l
zrtgp6oqmJ~#0JU42Tjsv8A`Db21^=)o)VTzBxs%e9G`<6hg>Vt5>u&XgR?DYfHP|z
z?tm`EOeiLIj_P%@1iL;Pt|3MXX81f=vQn_AL`zaTEXYEW0V<G-TyR(i^r=PxRn(=5
zr)U@~T`^k0emY7=ahv<4FFGk?W!Vy47#l{b4uH~a3swQ(1NsO&Ksdcam{wl9AYGLl
z7pz#@C$%jUmsN(=!mE|lQEcp6n^=|j#TY&@m04ZDyTM!+2(yZn8M&G9x!utG2b=<M
z6gdpsd7ZC6w>`0gQ>hGdp)iYKcNZeNmsQ+p5y8amw~lxSKP`9AgzoOa)~}|JZI6~%
zrRPG;#tmz&z4P>WmjUlQNW&-*#%6%MJwTE|nIseBh9<EK-0BAVA}@u?^ktf9UO9no
zJ=;SjQ(8XiAbU?A`AdL&)TMaw{C>2No}ME&Q9A^$J8ez!O4aI)fk~+^soQff8m0&g
znxH=5AOL)VSA{N(9n_pv(m*6sQJM6dqIL4U`c^V&Cy<qluO1Mp3U`jcZ$i7-Px&E8
z`O4L5Kr6J5)c&oC1d`a`R*gvm)P2#s7Ol&6+syBUHw*B7+;N=;jXiW%c=c&{?Jllg
zbi(bJebWo9CwnmLUg<Y(9Eq2ruq7jxti-$i2HI%w(ftyRf)YkP4pvHkeS2~|_7fYZ
Px~}FQ(+@Eeq6Po}RVPs}