diff --git a/.drone.yml b/.drone.yml
index eb0a0c0454b80..8b15c95c4d2f0 100644
--- a/.drone.yml
+++ b/.drone.yml
@@ -53,7 +53,6 @@ steps:
- name: php80-unit
depends_on: [ phpcs ]
image: joomlaprojects/docker-images:php8.0
- failure: ignore
commands:
- php -v
- ./libraries/vendor/bin/phpunit --testsuite Unit
@@ -98,7 +97,13 @@ steps:
- name: php81-integration
depends_on: [ npm ]
image: joomlaprojects/docker-images:php8.1
- failure: ignore
+ commands:
+ - php -v
+ - ./libraries/vendor/bin/phpunit --testsuite Integration
+
+ - name: php82-integration
+ depends_on: [ npm ]
+ image: joomlaprojects/docker-images:php8.2
commands:
- php -v
- ./libraries/vendor/bin/phpunit --testsuite Integration
@@ -135,7 +140,13 @@ steps:
- name: php81-integration-pgsql
depends_on: [ npm ]
image: joomlaprojects/docker-images:php8.1
- failure: ignore
+ commands:
+ - php -v
+ - ./libraries/vendor/bin/phpunit --testsuite Integration --configuration phpunit-pgsql.xml.dist
+
+ - name: php82-integration-pgsql
+ depends_on: [ npm ]
+ image: joomlaprojects/docker-images:php8.2
commands:
- php -v
- ./libraries/vendor/bin/phpunit --testsuite Integration --configuration phpunit-pgsql.xml.dist
@@ -152,41 +163,164 @@ steps:
commands:
- npm run lint:js
- - name: system-tests-mysql
- depends_on: [ javascript-cs ]
+ - name: phpmin-api-mysql
+ depends_on:
+ - javascript-cs
image: joomlaprojects/docker-images:systemtests
environment:
JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
commands:
- - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysql
+ - bash tests/Codeception/drone-api-run.sh "$(pwd)" mysql
+
+ - name: phpmax-api-mysql
+ depends_on:
+ - phpmin-api-mysql
+ image: joomlaprojects/docker-images:systemtests8.1
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-api-run.sh "$(pwd)" mysql
- - name: system-tests-mysql8
- depends_on: [ system-tests-mysql ]
+ - name: phpnext-api-mysql
+ depends_on:
+ - phpmin-api-mysql
+ image: joomlaprojects/docker-images:systemtests8.2
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-api-run.sh "$(pwd)" mysqlphpnext
+
+ - name: phpmin-api-postgres
+ depends_on:
+ - phpnext-api-mysql
image: joomlaprojects/docker-images:systemtests
+ failure: ignore
environment:
JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
commands:
- - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysql8
+ - bash tests/Codeception/drone-api-run.sh "$(pwd)" postgres
- - name: system-tests-postgres
- depends_on: [ system-tests-mysql8 ]
+ - name: phpnext-api-postgres
+ depends_on:
+ - phpmin-api-postgres
+ image: joomlaprojects/docker-images:systemtests8.2
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-api-run.sh "$(pwd)" postgresphpnext
+
+ - name: phpmax-api-postgres
+ depends_on:
+ - phpnext-api-postgres
+ image: joomlaprojects/docker-images:systemtests8.1
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-api-run.sh "$(pwd)" postgres
+
+ - name: phpmin-system-mysql
+ depends_on:
+ - javascript-cs
+ - phpmax-api-postgres
image: joomlaprojects/docker-images:systemtests
+ failure: ignore
environment:
JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
commands:
- - bash tests/Codeception/drone-system-run.sh "$(pwd)" postgres
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysql
+
+ - name: phpnext-system-mysql
+ depends_on: [ phpmin-system-mysql ]
+ image: joomlaprojects/docker-images:systemtests8.2
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysqlphpnext
+
+ - name: phpmax-system-mysql
+ depends_on: [ phpnext-system-mysql ]
+ image: joomlaprojects/docker-images:systemtests8.1
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysqlphpmax
+
+ - name: phpnext-system-mysql8
+ depends_on: [ phpmax-system-mysql ]
+ image: joomlaprojects/docker-images:systemtests8.2
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysql8phpnext
+
+ - name: phpmax-system-mysql8
+ depends_on: [ phpnext-system-mysql ]
+ image: joomlaprojects/docker-images:systemtests8.1
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysql8phpmax
+
+ - name: phpnext-system-postgres
+ depends_on: [ phpmax-system-mysql8 ]
+ image: joomlaprojects/docker-images:systemtests8.2
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" postgresphpnext
- - name: api-tests
- depends_on: [ system-tests-postgres ]
+ - name: phpmax-system-postgres
+ depends_on: [ phpnext-system-mysql8 ]
+ image: joomlaprojects/docker-images:systemtests8.1
+ failure: ignore
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" postgresphpmax
+
+ - name: phpmin-system-mysql8
+ depends_on: [ phpmax-system-postgres ]
image: joomlaprojects/docker-images:systemtests
environment:
JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
commands:
- - bash tests/Codeception/drone-api-run.sh "$(pwd)"
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" mysql8
+
+ - name: phpmin-system-postgres
+ depends_on: [ phpmin-system-mysql8 ]
+ image: joomlaprojects/docker-images:systemtests
+ environment:
+ JOOMLA_INSTALLATION_DISABLE_LOCALHOST_CHECK: 1
+ commands:
+ - bash tests/Codeception/drone-system-run.sh "$(pwd)" postgres
- name: artifacts-system-tests
image: cschlosser/drone-ftps
- depends_on: [ api-tests ]
+ depends_on:
+ - phpnext-system-mysql
+ - phpnext-system-mysql8
+ - phpnext-system-postgres
+ - phpmax-system-mysql
+ - phpmax-system-mysql8
+ - phpmax-system-postgres
+ - phpmin-system-mysql
+ - phpmin-system-mysql8
+ - phpmin-system-postgres
+ - phpnext-api-mysql
+ - phpnext-api-postgres
+ - phpmax-api-mysql
+ - phpmax-api-postgres
+ - phpmin-api-mysql
+ - phpmin-api-postgres
environment:
FTP_USERNAME:
from_secret: ftpusername
@@ -209,9 +343,9 @@ branches:
exclude: [ l10n_* ]
volumes:
-- name: composer-cache
- host:
- path: /tmp/composer-cache
+ - name: composer-cache
+ host:
+ path: /tmp/composer-cache
services:
- name: mysql
@@ -275,6 +409,6 @@ steps:
---
kind: signature
-hmac: bd749550476cef0ec9258524e7f158b25dd3adf55758bb1c24874a185db1b40a
+hmac: e93522732dd8607448fa7705982c42c06f9ebf9762023ed1bb2207ee975fee42
...
diff --git a/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php b/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php
index 5846ce6fc9157..2b39293c8970c 100644
--- a/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php
+++ b/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php
@@ -40,7 +40,7 @@ class ActionlogsController extends AdminController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.9.0
diff --git a/administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php b/administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php
index 411d9c267d42e..264d67612f67a 100644
--- a/administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php
+++ b/administrator/components/com_actionlogs/src/Helper/ActionlogsHelper.php
@@ -16,6 +16,7 @@
use Joomla\CMS\Factory;
use Joomla\CMS\Filesystem\Path;
use Joomla\CMS\Language\Text;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Router\Route;
use Joomla\String\StringHelper;
@@ -30,6 +31,7 @@ class ActionlogsHelper
* Array of characters starting a formula
*
* @var array
+ *
* @since 3.9.7
*/
private static $characters = array('=', '+', '-', '@');
@@ -42,6 +44,7 @@ class ActionlogsHelper
* @return Generator
*
* @since 3.9.0
+ *
* @throws \InvalidArgumentException
*/
public static function getCsvData($data): Generator
@@ -173,8 +176,8 @@ public static function getLogContentTypeParams($context)
/**
* Get human readable log message for a User Action Log
*
- * @param stdClass $log A User Action log message record
- * @param boolean $generateLinks Flag to disable link generation when creating a message
+ * @param \stdClass $log A User Action log message record
+ * @param boolean $generateLinks Flag to disable link generation when creating a message
*
* @return string
*
@@ -233,11 +236,11 @@ public static function getHumanReadableLogMessage($log, $generateLinks = true)
/**
* Get link to an item of given content type
*
- * @param string $component
- * @param string $contentType
- * @param integer $id
- * @param string $urlVar
- * @param JObject $object
+ * @param string $component
+ * @param string $contentType
+ * @param integer $id
+ * @param string $urlVar
+ * @param CMSObject $object
*
* @return string Link to the content item
*
diff --git a/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php b/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php
index 854164246d54a..02bc88d86508e 100644
--- a/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php
+++ b/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php
@@ -269,7 +269,7 @@ public function getLogsForItem($extension, $itemId)
}
/**
- * Get logs data into JTable object
+ * Get logs data into Table object
*
* @param integer[]|null $pks An optional array of log record IDs to load
*
diff --git a/administrator/components/com_admin/script.php b/administrator/components/com_admin/script.php
index f0a15a311f0a9..54e4967630255 100644
--- a/administrator/components/com_admin/script.php
+++ b/administrator/components/com_admin/script.php
@@ -6110,7 +6110,9 @@ public function deleteUnexistingFiles($dryRun = false, $suppressOutput = false)
'/templates/cassiopeia/images/system/sort_desc.png',
// From 4.0.4 to 4.0.5
'/media/vendor/codemirror/lib/#codemirror.js#',
- // From 4.0.5 to 4.1.0
+ // From 4.0.5 to 4.0.6
+ '/media/vendor/mediaelement/css/mejs-controls.png',
+ // From 4.0.x to 4.1.0
'/administrator/templates/atum/css/system/searchtools/searchtools.css',
'/administrator/templates/atum/css/system/searchtools/searchtools.min.css',
'/administrator/templates/atum/css/system/searchtools/searchtools.min.css.gz',
@@ -7727,7 +7729,7 @@ public function updateAssets($installer)
foreach ($newComponents as $component)
{
- /** @var JTableAsset $asset */
+ /** @var \Joomla\CMS\Table\Asset $asset */
$asset = Table::getInstance('Asset');
if ($asset->loadByName($component))
diff --git a/administrator/components/com_admin/sql/updates/mysql/4.0.6-2021-12-23.sql b/administrator/components/com_admin/sql/updates/mysql/4.0.6-2021-12-23.sql
new file mode 100644
index 0000000000000..427c568298630
--- /dev/null
+++ b/administrator/components/com_admin/sql/updates/mysql/4.0.6-2021-12-23.sql
@@ -0,0 +1 @@
+UPDATE `#__extensions` SET `checked_out` = NULL WHERE `type` = 'package' AND `element` = 'pkg_search' AND `checked_out` = 0;
diff --git a/administrator/components/com_admin/sql/updates/postgresql/4.0.6-2021-12-23.sql b/administrator/components/com_admin/sql/updates/postgresql/4.0.6-2021-12-23.sql
new file mode 100644
index 0000000000000..e22866913afe2
--- /dev/null
+++ b/administrator/components/com_admin/sql/updates/postgresql/4.0.6-2021-12-23.sql
@@ -0,0 +1 @@
+UPDATE "#__extensions" SET "checked_out" = NULL WHERE "type" = 'package' AND "element" = 'pkg_search' AND "checked_out" = 0;
diff --git a/administrator/components/com_associations/src/Field/Modal/AssociationField.php b/administrator/components/com_associations/src/Field/Modal/AssociationField.php
index b008ad334be61..f05d89046b30d 100644
--- a/administrator/components/com_associations/src/Field/Modal/AssociationField.php
+++ b/administrator/components/com_associations/src/Field/Modal/AssociationField.php
@@ -41,7 +41,7 @@ class AssociationField extends FormField
*/
protected function getInput()
{
- // @TODO USE JLayouts here!!!
+ // @todo USE Layouts here!!!
// The active item id field.
$value = (int) $this->value ?: '';
diff --git a/administrator/components/com_associations/src/Model/AssociationModel.php b/administrator/components/com_associations/src/Model/AssociationModel.php
index 93cf014b912ae..54796fdedad5a 100644
--- a/administrator/components/com_associations/src/Model/AssociationModel.php
+++ b/administrator/components/com_associations/src/Model/AssociationModel.php
@@ -26,7 +26,7 @@ class AssociationModel extends ListModel
* @param array $data Data for the form.
* @param boolean $loadData True if the form is to load its own data (default case), false if not.
*
- * @return mixed A \JForm object on success, false on failure
+ * @return \Joomla\CMS\Form\Form|boolean A Form object on success, false on failure
*
* @since 3.7.0
*/
diff --git a/administrator/components/com_associations/src/Model/AssociationsModel.php b/administrator/components/com_associations/src/Model/AssociationsModel.php
index 0bcaa00f25ef3..71b28b4cf1bbb 100644
--- a/administrator/components/com_associations/src/Model/AssociationsModel.php
+++ b/administrator/components/com_associations/src/Model/AssociationsModel.php
@@ -155,7 +155,7 @@ protected function getStoreId($id = '')
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery|boolean
+ * @return \Joomla\Database\DatabaseQuery|boolean
*
* @since 3.7.0
*/
diff --git a/administrator/components/com_banners/src/Controller/BannersController.php b/administrator/components/com_banners/src/Controller/BannersController.php
index 75fe2e141631c..aa47e8c39c729 100644
--- a/administrator/components/com_banners/src/Controller/BannersController.php
+++ b/administrator/components/com_banners/src/Controller/BannersController.php
@@ -38,7 +38,7 @@ class BannersController extends AdminController
*
* @param array $config An optional associative array of configuration settings.
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.0
diff --git a/administrator/components/com_banners/src/Model/BannersModel.php b/administrator/components/com_banners/src/Model/BannersModel.php
index 6a18caa75c738..e0838007fa9ed 100644
--- a/administrator/components/com_banners/src/Model/BannersModel.php
+++ b/administrator/components/com_banners/src/Model/BannersModel.php
@@ -93,7 +93,7 @@ public function &getCategoryOrders()
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 1.6
*/
diff --git a/administrator/components/com_banners/src/Model/ClientModel.php b/administrator/components/com_banners/src/Model/ClientModel.php
index c66392fa90b9b..bbe474d565744 100644
--- a/administrator/components/com_banners/src/Model/ClientModel.php
+++ b/administrator/components/com_banners/src/Model/ClientModel.php
@@ -85,7 +85,7 @@ protected function canEditState($record)
* @param array $data Data for the form.
* @param boolean $loadData True if the form is to load its own data (default case), false if not.
*
- * @return \JForm|boolean A \JForm object on success, false on failure
+ * @return \Joomla\CMS\Form\Form|boolean A Form object on success, false on failure
*
* @since 1.6
*/
diff --git a/administrator/components/com_banners/src/Model/ClientsModel.php b/administrator/components/com_banners/src/Model/ClientsModel.php
index da569440e06fc..b0e7b3aa141c8 100644
--- a/administrator/components/com_banners/src/Model/ClientsModel.php
+++ b/administrator/components/com_banners/src/Model/ClientsModel.php
@@ -92,7 +92,7 @@ protected function getStoreId($id = '')
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery
+ * @return \Joomla\Database\DatabaseQuery
*/
protected function getListQuery()
{
@@ -162,7 +162,7 @@ protected function getListQuery()
);
// Filter by search in title
- if ($search = trim($this->getState('filter.search')))
+ if ($search = trim($this->getState('filter.search', '')))
{
if (stripos($search, 'id:') === 0)
{
diff --git a/administrator/components/com_banners/src/Model/DownloadModel.php b/administrator/components/com_banners/src/Model/DownloadModel.php
index 97c60a109ce27..5cd2d4ff61a11 100644
--- a/administrator/components/com_banners/src/Model/DownloadModel.php
+++ b/administrator/components/com_banners/src/Model/DownloadModel.php
@@ -52,7 +52,7 @@ protected function populateState()
* @param array $data Data for the form.
* @param boolean $loadData True if the form is to load its own data (default case), false if not.
*
- * @return \JForm|boolean A JForm object on success, false on failure
+ * @return \Joomla\CMS\Form\Form|boolean A Form object on success, false on failure
*
* @since 1.6
*/
diff --git a/administrator/components/com_banners/src/Model/TracksModel.php b/administrator/components/com_banners/src/Model/TracksModel.php
index 17597aa89ffd9..dd353dfb7360c 100644
--- a/administrator/components/com_banners/src/Model/TracksModel.php
+++ b/administrator/components/com_banners/src/Model/TracksModel.php
@@ -84,7 +84,7 @@ protected function populateState($ordering = 'b.name', $direction = 'asc')
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 1.6
*/
diff --git a/administrator/components/com_categories/src/Controller/CategoryController.php b/administrator/components/com_categories/src/Controller/CategoryController.php
index 47df1f6d63616..d07ae3f0a54c2 100644
--- a/administrator/components/com_categories/src/Controller/CategoryController.php
+++ b/administrator/components/com_categories/src/Controller/CategoryController.php
@@ -41,7 +41,7 @@ class CategoryController extends FormController
*
* @param array $config An optional associative array of configuration settings.
* @param MVCFactoryInterface|null $factory The factory.
- * @param CMSApplication|null $app The JApplication for the dispatcher
+ * @param CMSApplication|null $app The Application for the dispatcher
* @param Input|null $input Input
*
* @since 1.6
diff --git a/administrator/components/com_categories/src/Controller/DisplayController.php b/administrator/components/com_categories/src/Controller/DisplayController.php
index 4b92cba3bf700..5f9ab4ae35db5 100644
--- a/administrator/components/com_categories/src/Controller/DisplayController.php
+++ b/administrator/components/com_categories/src/Controller/DisplayController.php
@@ -46,7 +46,7 @@ class DisplayController extends BaseController
*
* @param array $config An optional associative array of configuration settings.
* @param MVCFactoryInterface|null $factory The factory.
- * @param CMSApplication|null $app The JApplication for the dispatcher
+ * @param CMSApplication|null $app The Application for the dispatcher
* @param Input|null $input Input
*
* @since 3.0
diff --git a/administrator/components/com_categories/src/Model/CategoriesModel.php b/administrator/components/com_categories/src/Model/CategoriesModel.php
index c7deef7886bb2..f2d9b811c36a1 100644
--- a/administrator/components/com_categories/src/Model/CategoriesModel.php
+++ b/administrator/components/com_categories/src/Model/CategoriesModel.php
@@ -156,7 +156,7 @@ protected function getStoreId($id = '')
/**
* Method to get a database query to list categories.
*
- * @return \JDatabaseQuery object.
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 1.6
*/
diff --git a/administrator/components/com_categories/src/Model/CategoryModel.php b/administrator/components/com_categories/src/Model/CategoryModel.php
index 69155cfd9c246..cdff9e7b88b5b 100644
--- a/administrator/components/com_categories/src/Model/CategoryModel.php
+++ b/administrator/components/com_categories/src/Model/CategoryModel.php
@@ -150,7 +150,7 @@ protected function canEditState($record)
* @param string $prefix The class prefix. Optional.
* @param array $config Configuration array for model. Optional.
*
- * @return \Joomla\CMS\Table\Table A JTable object
+ * @return \Joomla\CMS\Table\Table A Table object
*
* @since 1.6
*/
@@ -397,15 +397,17 @@ public function validate($form, $data, $group = null)
/**
* Method to preprocess the form.
*
- * @param \JForm $form A JForm object.
- * @param mixed $data The data expected for the form.
- * @param string $group The name of the plugin group to import.
+ * @param Form $form A Form object.
+ * @param mixed $data The data expected for the form.
+ * @param string $group The name of the plugin group to import.
*
* @return mixed
*
- * @see \Joomla\CMS\Form\FormField
* @since 1.6
+ *
* @throws \Exception if there is an error in the form event.
+ *
+ * @see \Joomla\CMS\Form\FormField
*/
protected function preprocessForm(Form $form, $data, $group = 'content')
{
diff --git a/administrator/components/com_categories/src/Table/CategoryTable.php b/administrator/components/com_categories/src/Table/CategoryTable.php
index 9711bdee02544..dc63e189a81da 100644
--- a/administrator/components/com_categories/src/Table/CategoryTable.php
+++ b/administrator/components/com_categories/src/Table/CategoryTable.php
@@ -16,7 +16,7 @@
*
* @since 1.6
*/
-class CategoryTable extends \JTableCategory
+class CategoryTable extends \Joomla\CMS\Table\Category
{
/**
* Method to delete a node and, optionally, its child nodes from the table.
diff --git a/administrator/components/com_categories/src/View/Categories/HtmlView.php b/administrator/components/com_categories/src/View/Categories/HtmlView.php
index 809e92e96ee36..0e13a38583bb3 100644
--- a/administrator/components/com_categories/src/View/Categories/HtmlView.php
+++ b/administrator/components/com_categories/src/View/Categories/HtmlView.php
@@ -61,7 +61,7 @@ class HtmlView extends BaseHtmlView
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
public $filterForm;
diff --git a/administrator/components/com_categories/src/View/Category/HtmlView.php b/administrator/components/com_categories/src/View/Category/HtmlView.php
index baaf30b041067..71d1a50119ec7 100644
--- a/administrator/components/com_categories/src/View/Category/HtmlView.php
+++ b/administrator/components/com_categories/src/View/Category/HtmlView.php
@@ -19,6 +19,7 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\GenericDataException;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
/**
@@ -29,9 +30,9 @@
class HtmlView extends BaseHtmlView
{
/**
- * The \JForm object
+ * The Form object
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
protected $form;
@@ -45,7 +46,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var CMSObject
*/
protected $state;
@@ -59,7 +60,7 @@ class HtmlView extends BaseHtmlView
/**
* The actions the user is authorised to perform
*
- * @var \JObject
+ * @var CMSObject
*/
protected $canDo;
diff --git a/administrator/components/com_checkin/src/View/Checkin/HtmlView.php b/administrator/components/com_checkin/src/View/Checkin/HtmlView.php
index e5ca226a4536e..7bb8218f1611d 100644
--- a/administrator/components/com_checkin/src/View/Checkin/HtmlView.php
+++ b/administrator/components/com_checkin/src/View/Checkin/HtmlView.php
@@ -41,14 +41,15 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
@@ -57,6 +58,7 @@ class HtmlView extends BaseHtmlView
* The active search filters
*
* @var array
+ *
* @since 4.0.0
*/
public $activeFilters;
@@ -64,7 +66,8 @@ class HtmlView extends BaseHtmlView
/**
* Is this view an Empty State
*
- * @var boolean
+ * @var boolean
+ *
* @since 4.0.0
*/
private $isEmptyState = false;
diff --git a/administrator/components/com_config/src/Controller/ApplicationController.php b/administrator/components/com_config/src/Controller/ApplicationController.php
index 47fd7ccaf2fb5..9fc6687c48cab 100644
--- a/administrator/components/com_config/src/Controller/ApplicationController.php
+++ b/administrator/components/com_config/src/Controller/ApplicationController.php
@@ -34,7 +34,7 @@ class ApplicationController extends BaseController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.0
diff --git a/administrator/components/com_config/src/Controller/ComponentController.php b/administrator/components/com_config/src/Controller/ComponentController.php
index ca03d246b00e3..a7718e366b545 100644
--- a/administrator/components/com_config/src/Controller/ComponentController.php
+++ b/administrator/components/com_config/src/Controller/ComponentController.php
@@ -33,7 +33,7 @@ class ComponentController extends FormController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.0
diff --git a/administrator/components/com_config/src/Controller/DisplayController.php b/administrator/components/com_config/src/Controller/DisplayController.php
index 7a5b66263169a..2ed6a6f030c14 100644
--- a/administrator/components/com_config/src/Controller/DisplayController.php
+++ b/administrator/components/com_config/src/Controller/DisplayController.php
@@ -47,7 +47,7 @@ class DisplayController extends BaseController
*/
public function display($cachable = false, $urlparams = array())
{
- $component = $this->input->get('component');
+ $component = $this->input->get('component', '');
// Make sure com_joomlaupdate and com_privacy can only be accessed by SuperUser
if (in_array(strtolower($component), array('com_joomlaupdate', 'com_privacy'))
diff --git a/administrator/components/com_config/src/Model/ApplicationModel.php b/administrator/components/com_config/src/Model/ApplicationModel.php
index 1a24f00610579..c907e1bbb4435 100644
--- a/administrator/components/com_config/src/Model/ApplicationModel.php
+++ b/administrator/components/com_config/src/Model/ApplicationModel.php
@@ -20,6 +20,7 @@
use Joomla\CMS\Filesystem\File;
use Joomla\CMS\Filesystem\Folder;
use Joomla\CMS\Filesystem\Path;
+use Joomla\CMS\Filter\OutputFilter;
use Joomla\CMS\Http\HttpFactory;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Log\Log;
@@ -495,7 +496,7 @@ public function save($data)
// Escape the offline message if present.
if (isset($data['offline_message']))
{
- $data['offline_message'] = \JFilterOutput::ampReplace($data['offline_message']);
+ $data['offline_message'] = OutputFilter::ampReplace($data['offline_message']);
}
// Purge the database session table if we are changing to the database handler.
@@ -1090,7 +1091,7 @@ public function storePermissions($permission = null)
}
/**
- * @to do: incorrect ACL stored
+ * @todo: incorrect ACL stored
* When changing a permission of an item that doesn't have a row in the asset table the row a new row is created.
* This works fine for item <-> component <-> global config scenario and component <-> global config scenario.
* But doesn't work properly for item <-> section(s) <-> component <-> global config scenario,
@@ -1184,7 +1185,7 @@ public function storePermissions($permission = null)
$parentAssetId = null;
/**
- * @to do: incorrect info
+ * @todo: incorrect info
* When creating a new item (not saving) it uses the calculated permissions from the component (item <-> component <-> global config).
* But if we have a section too (item <-> section(s) <-> component <-> global config) this is not correct.
* Also, currently it uses the component permission, but should use the calculated permissions for a child of the component/section.
@@ -1285,7 +1286,7 @@ public function storePermissions($permission = null)
// Second part: Overwrite the calculated permissions labels if there is an explicit permission in the current group.
/**
- * @to do: incorrect info
+ * @todo: incorrect info
* If a component has a permission that doesn't exists in global config (ex: frontend editing in com_modules) by default
* we get "Not Allowed (Inherited)" when we should get "Not Allowed (Default)".
*/
diff --git a/administrator/components/com_config/src/View/Application/HtmlView.php b/administrator/components/com_config/src/View/Application/HtmlView.php
index 1d7aa4c9d64fe..c750bffa0b603 100644
--- a/administrator/components/com_config/src/View/Application/HtmlView.php
+++ b/administrator/components/com_config/src/View/Application/HtmlView.php
@@ -72,7 +72,7 @@ public function display($tpl = null)
{
Factory::getApplication()->enqueueMessage($e->getMessage(), 'error');
- return false;
+ return;
}
// Bind data
diff --git a/administrator/components/com_contact/src/Controller/ContactsController.php b/administrator/components/com_contact/src/Controller/ContactsController.php
index 90b0553b4031f..ced77a0031adf 100644
--- a/administrator/components/com_contact/src/Controller/ContactsController.php
+++ b/administrator/components/com_contact/src/Controller/ContactsController.php
@@ -32,7 +32,7 @@ class ContactsController extends AdminController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.0
diff --git a/administrator/components/com_contact/src/Model/ContactsModel.php b/administrator/components/com_contact/src/Model/ContactsModel.php
index 2ac3ce8f57b6b..cd24dc0066e37 100644
--- a/administrator/components/com_contact/src/Model/ContactsModel.php
+++ b/administrator/components/com_contact/src/Model/ContactsModel.php
@@ -137,7 +137,7 @@ protected function getStoreId($id = '')
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 1.6
*/
diff --git a/administrator/components/com_contact/src/Table/ContactTable.php b/administrator/components/com_contact/src/Table/ContactTable.php
index 57f0d3e28b6e0..b1f86ee8cf205 100644
--- a/administrator/components/com_contact/src/Table/ContactTable.php
+++ b/administrator/components/com_contact/src/Table/ContactTable.php
@@ -13,6 +13,7 @@
use Joomla\CMS\Application\ApplicationHelper;
use Joomla\CMS\Factory;
+use Joomla\CMS\Filter\InputFilter;
use Joomla\CMS\Language\Text;
use Joomla\CMS\String\PunycodeHelper;
use Joomla\CMS\Table\Table;
@@ -150,7 +151,7 @@ public function check()
$this->default_con = (int) $this->default_con;
- if (\JFilterInput::checkAttribute(array('href', $this->webpage)))
+ if (InputFilter::checkAttribute(array('href', $this->webpage)))
{
$this->setError(Text::_('COM_CONTACT_WARNING_PROVIDE_VALID_URL'));
diff --git a/administrator/components/com_contact/src/View/Contact/HtmlView.php b/administrator/components/com_contact/src/View/Contact/HtmlView.php
index b0ce39f06ff22..018cde07ce84c 100644
--- a/administrator/components/com_contact/src/View/Contact/HtmlView.php
+++ b/administrator/components/com_contact/src/View/Contact/HtmlView.php
@@ -29,9 +29,9 @@
class HtmlView extends BaseHtmlView
{
/**
- * The \JForm object
+ * The Form object
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
protected $form;
@@ -45,7 +45,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
diff --git a/administrator/components/com_contact/src/View/Contacts/HtmlView.php b/administrator/components/com_contact/src/View/Contacts/HtmlView.php
index ad67e06c62f70..ff8aee3ab133a 100644
--- a/administrator/components/com_contact/src/View/Contacts/HtmlView.php
+++ b/administrator/components/com_contact/src/View/Contacts/HtmlView.php
@@ -37,21 +37,21 @@ class HtmlView extends BaseHtmlView
/**
* The pagination object
*
- * @var \JPagination
+ * @var \Joomla\CMS\Pagination\Pagination
*/
protected $pagination;
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
public $filterForm;
@@ -65,7 +65,8 @@ class HtmlView extends BaseHtmlView
/**
* Is this view an Empty State
*
- * @var boolean
+ * @var boolean
+ *
* @since 4.0.0
*/
private $isEmptyState = false;
diff --git a/administrator/components/com_content/forms/article.xml b/administrator/components/com_content/forms/article.xml
index 3b6ad8bcd589d..a71ec8438528c 100644
--- a/administrator/components/com_content/forms/article.xml
+++ b/administrator/components/com_content/forms/article.xml
@@ -793,6 +793,7 @@
name="float_fulltext"
type="text"
label="COM_CONTENT_FIELD_IMAGE_CLASS_LABEL"
+ description="COM_CONTENT_FIELD_IMAGE_CLASS_DESC"
size="20"
/>
diff --git a/administrator/components/com_content/src/Controller/ArticleController.php b/administrator/components/com_content/src/Controller/ArticleController.php
index 27a76274978ba..4147cb5b7de04 100644
--- a/administrator/components/com_content/src/Controller/ArticleController.php
+++ b/administrator/components/com_content/src/Controller/ArticleController.php
@@ -36,7 +36,7 @@ class ArticleController extends FormController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.0
diff --git a/administrator/components/com_content/src/Controller/ArticlesController.php b/administrator/components/com_content/src/Controller/ArticlesController.php
index a037239355c1e..6bfa1850b484e 100644
--- a/administrator/components/com_content/src/Controller/ArticlesController.php
+++ b/administrator/components/com_content/src/Controller/ArticlesController.php
@@ -34,7 +34,7 @@ class ArticlesController extends AdminController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.0
@@ -86,29 +86,31 @@ public function featured()
if (empty($ids))
{
$this->app->enqueueMessage(Text::_('JERROR_NO_ITEMS_SELECTED'), 'error');
+
+ $this->setRedirect(Route::_($redirectUrl, false));
+
+ return;
}
- else
- {
- // Get the model.
- /** @var \Joomla\Component\Content\Administrator\Model\ArticleModel $model */
- $model = $this->getModel();
- // Publish the items.
- if (!$model->featured($ids, $value))
- {
- $this->setRedirect(Route::_($redirectUrl, false), $model->getError(), 'error');
+ // Get the model.
+ /** @var \Joomla\Component\Content\Administrator\Model\ArticleModel $model */
+ $model = $this->getModel();
- return;
- }
+ // Publish the items.
+ if (!$model->featured($ids, $value))
+ {
+ $this->setRedirect(Route::_($redirectUrl, false), $model->getError(), 'error');
- if ($value == 1)
- {
- $message = Text::plural('COM_CONTENT_N_ITEMS_FEATURED', count($ids));
- }
- else
- {
- $message = Text::plural('COM_CONTENT_N_ITEMS_UNFEATURED', count($ids));
- }
+ return;
+ }
+
+ if ($value == 1)
+ {
+ $message = Text::plural('COM_CONTENT_N_ITEMS_FEATURED', count($ids));
+ }
+ else
+ {
+ $message = Text::plural('COM_CONTENT_N_ITEMS_UNFEATURED', count($ids));
}
$this->setRedirect(Route::_($redirectUrl, false), $message);
@@ -131,9 +133,9 @@ public function getModel($name = 'Article', $prefix = 'Administrator', $config =
}
/**
- * Method to get the number of published articles for quickicons
+ * Method to get the JSON-encoded amount of published articles
*
- * @return string The JSON-encoded amount of published articles
+ * @return void
*
* @since 4.0.0
*/
diff --git a/administrator/components/com_content/src/Table/ArticleTable.php b/administrator/components/com_content/src/Table/ArticleTable.php
index c8eed0e1e5d96..35d8f589f7254 100644
--- a/administrator/components/com_content/src/Table/ArticleTable.php
+++ b/administrator/components/com_content/src/Table/ArticleTable.php
@@ -16,6 +16,6 @@
*
* @since 1.5
*/
-class ArticleTable extends \JTableContent
+class ArticleTable extends \Joomla\CMS\Table\Content
{
}
diff --git a/administrator/components/com_content/src/View/Article/HtmlView.php b/administrator/components/com_content/src/View/Article/HtmlView.php
index f04a9c76e16f9..45af8a50c80da 100644
--- a/administrator/components/com_content/src/View/Article/HtmlView.php
+++ b/administrator/components/com_content/src/View/Article/HtmlView.php
@@ -34,7 +34,7 @@ class HtmlView extends BaseHtmlView
/**
* The \JForm object
*
- * @var \Joomla\CMS\Form\Form
+ * @var \Joomla\CMS\Form\Form
*/
protected $form;
@@ -55,7 +55,7 @@ class HtmlView extends BaseHtmlView
/**
* The actions the user is authorised to perform
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $canDo;
@@ -73,8 +73,9 @@ class HtmlView extends BaseHtmlView
*
* @return void
*
- * @throws \Exception
* @since 1.6
+ *
+ * @throws \Exception
*/
public function display($tpl = null)
{
@@ -120,8 +121,9 @@ public function display($tpl = null)
*
* @return void
*
- * @throws \Exception
* @since 1.6
+ *
+ * @throws \Exception
*/
protected function addToolbar()
{
diff --git a/administrator/components/com_content/src/View/Articles/HtmlView.php b/administrator/components/com_content/src/View/Articles/HtmlView.php
index 4fa3b62a04bd9..deb7a7c86b6fd 100644
--- a/administrator/components/com_content/src/View/Articles/HtmlView.php
+++ b/administrator/components/com_content/src/View/Articles/HtmlView.php
@@ -40,21 +40,21 @@ class HtmlView extends BaseHtmlView
/**
* The pagination object
*
- * @var \JPagination
+ * @var \Joomla\CMS\Pagination\Pagination
*/
protected $pagination;
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
public $filterForm;
@@ -75,7 +75,7 @@ class HtmlView extends BaseHtmlView
/**
* Is this view an Empty State
*
- * @var boolean
+ * @var boolean
* @since 4.0.0
*/
private $isEmptyState = false;
diff --git a/administrator/components/com_content/src/View/Featured/HtmlView.php b/administrator/components/com_content/src/View/Featured/HtmlView.php
index cbcd31774948b..ca034b3767112 100644
--- a/administrator/components/com_content/src/View/Featured/HtmlView.php
+++ b/administrator/components/com_content/src/View/Featured/HtmlView.php
@@ -40,21 +40,21 @@ class HtmlView extends BaseHtmlView
/**
* The pagination object
*
- * @var \JPagination
+ * @var \Joomla\CMS\Pagination\Pagination
*/
protected $pagination;
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
public $filterForm;
diff --git a/administrator/components/com_content/tmpl/article/edit.php b/administrator/components/com_content/tmpl/article/edit.php
index fd9add68c9921..29ce01e10f511 100644
--- a/administrator/components/com_content/tmpl/article/edit.php
+++ b/administrator/components/com_content/tmpl/article/edit.php
@@ -37,16 +37,22 @@
$params = clone $this->state->get('params');
$params->merge(new Registry($this->item->attribs));
-$app = Factory::getApplication();
-$input = $app->input;
+$input = Factory::getApplication()->input;
-$assoc = Associations::isEnabled();
+$assoc = Associations::isEnabled();
+$showArticleOptions = $params->get('show_article_options', 1);
-if (!$assoc)
+if (!$assoc || !$showArticleOptions)
{
$this->ignore_fieldsets[] = 'frontendassociations';
}
+if (!$showArticleOptions)
+{
+ // Ignore fieldsets inside Options tab
+ $this->ignore_fieldsets = array_merge($this->ignore_fieldsets, ['attribs', 'basic', 'category', 'author', 'date', 'other']);
+}
+
// In case of modal
$isModal = $input->get('layout') === 'modal';
$layout = $isModal ? 'modal' : 'edit';
@@ -104,9 +110,7 @@
- get('show_article_options', 1) == 1) : ?>
-
-
+
get('show_publishing_options', 1) == 1) : ?>
diff --git a/administrator/components/com_contenthistory/src/Model/CompareModel.php b/administrator/components/com_contenthistory/src/Model/CompareModel.php
index d0eac29992736..7c0805a5f29c3 100644
--- a/administrator/components/com_contenthistory/src/Model/CompareModel.php
+++ b/administrator/components/com_contenthistory/src/Model/CompareModel.php
@@ -150,7 +150,7 @@ public function getTable($type = 'Contenthistory', $prefix = 'Joomla\\CMS\\Table
/**
* Method to test whether a record is editable
*
- * @param ContentHistory $record A \JTable object.
+ * @param ContentHistory $record A Table object.
*
* @return boolean True if allowed to edit the record. Defaults to the permission set in the component.
*
diff --git a/administrator/components/com_contenthistory/src/Model/HistoryModel.php b/administrator/components/com_contenthistory/src/Model/HistoryModel.php
index 41807701da43d..9109ffd8275ac 100644
--- a/administrator/components/com_contenthistory/src/Model/HistoryModel.php
+++ b/administrator/components/com_contenthistory/src/Model/HistoryModel.php
@@ -355,7 +355,7 @@ protected function populateState($ordering = 'h.save_date', $direction = 'DESC')
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 3.2
*/
diff --git a/administrator/components/com_contenthistory/src/View/Compare/HtmlView.php b/administrator/components/com_contenthistory/src/View/Compare/HtmlView.php
index d99233954556d..8759e6357c9d6 100644
--- a/administrator/components/com_contenthistory/src/View/Compare/HtmlView.php
+++ b/administrator/components/com_contenthistory/src/View/Compare/HtmlView.php
@@ -31,7 +31,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
diff --git a/administrator/components/com_contenthistory/src/View/History/HtmlView.php b/administrator/components/com_contenthistory/src/View/History/HtmlView.php
index ab47835f90691..77bbc7eb2c289 100644
--- a/administrator/components/com_contenthistory/src/View/History/HtmlView.php
+++ b/administrator/components/com_contenthistory/src/View/History/HtmlView.php
@@ -45,7 +45,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
diff --git a/administrator/components/com_contenthistory/src/View/Preview/HtmlView.php b/administrator/components/com_contenthistory/src/View/Preview/HtmlView.php
index ef1852477f27a..df61b6c29bac8 100644
--- a/administrator/components/com_contenthistory/src/View/Preview/HtmlView.php
+++ b/administrator/components/com_contenthistory/src/View/Preview/HtmlView.php
@@ -33,7 +33,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
diff --git a/administrator/components/com_fields/src/Controller/FieldController.php b/administrator/components/com_fields/src/Controller/FieldController.php
index 39a2e2f14f036..b0681ddb67185 100644
--- a/administrator/components/com_fields/src/Controller/FieldController.php
+++ b/administrator/components/com_fields/src/Controller/FieldController.php
@@ -52,7 +52,7 @@ class FieldController extends FormController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.7.0
diff --git a/administrator/components/com_fields/src/Controller/GroupController.php b/administrator/components/com_fields/src/Controller/GroupController.php
index dda1825e9b7df..1c644954aeed5 100644
--- a/administrator/components/com_fields/src/Controller/GroupController.php
+++ b/administrator/components/com_fields/src/Controller/GroupController.php
@@ -50,7 +50,7 @@ class GroupController extends FormController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 3.7.0
diff --git a/administrator/components/com_fields/src/Model/FieldModel.php b/administrator/components/com_fields/src/Model/FieldModel.php
index e8ba96f45115f..53633531ed44c 100644
--- a/administrator/components/com_fields/src/Model/FieldModel.php
+++ b/administrator/components/com_fields/src/Model/FieldModel.php
@@ -414,7 +414,7 @@ public function getItem($pk = null)
* @param string $prefix The class prefix. Optional.
* @param array $options Configuration array for model. Optional.
*
- * @return Table A JTable object
+ * @return Table A Table object
*
* @since 3.7.0
* @throws \Exception
@@ -504,7 +504,7 @@ public function delete(&$pks)
* @param array $data Data for the form.
* @param boolean $loadData True if the form is to load its own data (default case), false if not.
*
- * @return mixed A \JForm object on success, false on failure
+ * @return Form|bool A Form object on success, false on failure
*
* @since 3.7.0
*/
@@ -895,7 +895,7 @@ protected function populateState()
/**
* A protected method to get a set of ordering conditions.
*
- * @param Table $table A JTable object.
+ * @param Table $table A Table object.
*
* @return array An array of conditions to add to ordering queries.
*
@@ -985,15 +985,17 @@ public function validate($form, $data, $group = null)
/**
* Method to allow derived classes to preprocess the form.
*
- * @param \JForm $form A JForm object.
+ * @param Form $form A Form object.
* @param mixed $data The data expected for the form.
* @param string $group The name of the plugin group to import (defaults to "content").
*
* @return void
*
- * @see \Joomla\CMS\Form\FormField
* @since 3.7.0
+ *
* @throws \Exception if there is an error in the form event.
+ *
+ * @see \Joomla\CMS\Form\FormField
*/
protected function preprocessForm(Form $form, $data, $group = 'content')
{
diff --git a/administrator/components/com_fields/src/Model/FieldsModel.php b/administrator/components/com_fields/src/Model/FieldsModel.php
index 6c5f02afc47b8..b1ff50ae1070a 100644
--- a/administrator/components/com_fields/src/Model/FieldsModel.php
+++ b/administrator/components/com_fields/src/Model/FieldsModel.php
@@ -128,9 +128,9 @@ protected function getStoreId($id = '')
}
/**
- * Method to get a JDatabaseQuery object for retrieving the data set from a database.
+ * Method to get a DatabaseQuery object for retrieving the data set from a database.
*
- * @return \JDatabaseQuery A JDatabaseQuery object to retrieve the data set.
+ * @return \Joomla\Database\DatabaseQuery A DatabaseQuery object to retrieve the data set.
*
* @since 3.7.0
*/
@@ -449,7 +449,7 @@ protected function _getList($query, $limitstart = 0, $limit = 0)
* @param array $data data
* @param boolean $loadData load current data
*
- * @return \JForm|false the JForm object or false
+ * @return \Joomla\CMS\Form\Form|bool the Form object or false
*
* @since 3.7.0
*/
diff --git a/administrator/components/com_fields/src/Model/GroupModel.php b/administrator/components/com_fields/src/Model/GroupModel.php
index f80736f3e70f2..4cd9365565d09 100644
--- a/administrator/components/com_fields/src/Model/GroupModel.php
+++ b/administrator/components/com_fields/src/Model/GroupModel.php
@@ -74,7 +74,7 @@ public function save($data)
* @param string $prefix The class prefix. Optional.
* @param array $options Configuration array for model. Optional.
*
- * @return Table A JTable object
+ * @return Table A Table object
*
* @since 3.7.0
* @throws \Exception
diff --git a/administrator/components/com_fields/src/Model/GroupsModel.php b/administrator/components/com_fields/src/Model/GroupsModel.php
index b4edc4241a44a..914441fb489c3 100644
--- a/administrator/components/com_fields/src/Model/GroupsModel.php
+++ b/administrator/components/com_fields/src/Model/GroupsModel.php
@@ -116,9 +116,9 @@ protected function getStoreId($id = '')
}
/**
- * Method to get a JDatabaseQuery object for retrieving the data set from a database.
+ * Method to get a DatabaseQuery object for retrieving the data set from a database.
*
- * @return \JDatabaseQuery A JDatabaseQuery object to retrieve the data set.
+ * @return \Joomla\Database\DatabaseQuery A DatabaseQuery object to retrieve the data set.
*
* @since 3.7.0
*/
diff --git a/administrator/components/com_fields/src/Plugin/FieldsPlugin.php b/administrator/components/com_fields/src/Plugin/FieldsPlugin.php
index b72b54e3853e7..2c674e5a06cef 100644
--- a/administrator/components/com_fields/src/Plugin/FieldsPlugin.php
+++ b/administrator/components/com_fields/src/Plugin/FieldsPlugin.php
@@ -194,10 +194,10 @@ public function onCustomFieldsPrepareDom($field, \DOMElement $parent, Form $form
$node->setAttribute('name', $field->name);
$node->setAttribute('type', $field->type);
$node->setAttribute('label', $field->label);
- $node->setAttribute('labelclass', $field->params->get('label_class'));
+ $node->setAttribute('labelclass', $field->params->get('label_class', ''));
$node->setAttribute('description', $field->description);
- $node->setAttribute('class', $field->params->get('class'));
- $node->setAttribute('hint', $field->params->get('hint'));
+ $node->setAttribute('class', $field->params->get('class', ''));
+ $node->setAttribute('hint', $field->params->get('hint', ''));
$node->setAttribute('required', $field->required ? 'true' : 'false');
if ($field->default_value !== '')
diff --git a/administrator/components/com_fields/src/Table/FieldTable.php b/administrator/components/com_fields/src/Table/FieldTable.php
index 32757bca575c8..20953310ebe4c 100644
--- a/administrator/components/com_fields/src/Table/FieldTable.php
+++ b/administrator/components/com_fields/src/Table/FieldTable.php
@@ -269,7 +269,7 @@ protected function _getAssetTitle()
* The extended class can define a table and id to lookup. If the
* asset does not exist it will be created.
*
- * @param Table $table A JTable object for the asset parent.
+ * @param Table $table A Table object for the asset parent.
* @param integer $id Id to look up
*
* @return integer
diff --git a/administrator/components/com_fields/src/Table/GroupTable.php b/administrator/components/com_fields/src/Table/GroupTable.php
index 3898ba8e0b70a..474572238e4b6 100644
--- a/administrator/components/com_fields/src/Table/GroupTable.php
+++ b/administrator/components/com_fields/src/Table/GroupTable.php
@@ -195,7 +195,7 @@ protected function _getAssetTitle()
* The extended class can define a table and id to lookup. If the
* asset does not exist it will be created.
*
- * @param Table $table A JTable object for the asset parent.
+ * @param Table $table A Table object for the asset parent.
* @param integer $id Id to look up
*
* @return integer
diff --git a/administrator/components/com_fields/src/View/Field/HtmlView.php b/administrator/components/com_fields/src/View/Field/HtmlView.php
index 7b907261c00d7..8159b9ac9c6c9 100644
--- a/administrator/components/com_fields/src/View/Field/HtmlView.php
+++ b/administrator/components/com_fields/src/View/Field/HtmlView.php
@@ -17,6 +17,7 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\GenericDataException;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
/**
@@ -27,21 +28,21 @@
class HtmlView extends BaseHtmlView
{
/**
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*
* @since 3.7.0
*/
protected $form;
/**
- * @var \JObject
+ * @var CMSObject
*
* @since 3.7.0
*/
protected $item;
/**
- * @var \JObject
+ * @var CMSObject
*
* @since 3.7.0
*/
@@ -55,6 +56,7 @@ class HtmlView extends BaseHtmlView
* @return void
*
* @see HtmlView::loadTemplate()
+ *
* @since 3.7.0
*/
public function display($tpl = null)
diff --git a/administrator/components/com_fields/src/View/Fields/HtmlView.php b/administrator/components/com_fields/src/View/Fields/HtmlView.php
index c3b4342ac63f7..a536f8a19b879 100644
--- a/administrator/components/com_fields/src/View/Fields/HtmlView.php
+++ b/administrator/components/com_fields/src/View/Fields/HtmlView.php
@@ -32,7 +32,7 @@
class HtmlView extends BaseHtmlView
{
/**
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*
* @since 3.7.0
*/
@@ -53,14 +53,14 @@ class HtmlView extends BaseHtmlView
protected $items;
/**
- * @var \JPagination
+ * @var \Joomla\CMS\Pagination\Pagination
*
* @since 3.7.0
*/
protected $pagination;
/**
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*
* @since 3.7.0
*/
@@ -73,7 +73,8 @@ class HtmlView extends BaseHtmlView
*
* @return void
*
- * @see JViewLegacy::loadTemplate()
+ * @see \Joomla\CMS\MVC\View\HtmlView::loadTemplate()
+ *
* @since 3.7.0
*/
public function display($tpl = null)
diff --git a/administrator/components/com_fields/src/View/Group/HtmlView.php b/administrator/components/com_fields/src/View/Group/HtmlView.php
index 554951d8ddee0..0a10b060c31d2 100644
--- a/administrator/components/com_fields/src/View/Group/HtmlView.php
+++ b/administrator/components/com_fields/src/View/Group/HtmlView.php
@@ -17,6 +17,7 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\GenericDataException;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
use Joomla\Component\Fields\Administrator\Helper\FieldsHelper;
@@ -28,21 +29,21 @@
class HtmlView extends BaseHtmlView
{
/**
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*
* @since 3.7.0
*/
protected $form;
/**
- * @var \JObject
+ * @var CMSObject
*
* @since 3.7.0
*/
protected $item;
/**
- * @var \JObject
+ * @var CMSObject
*
* @since 3.7.0
*/
@@ -51,7 +52,7 @@ class HtmlView extends BaseHtmlView
/**
* The actions the user is authorised to perform
*
- * @var \JObject
+ * @var CMSObject
*
* @since 3.7.0
*/
@@ -66,6 +67,7 @@ class HtmlView extends BaseHtmlView
* @return void
*
* @see JViewLegacy::loadTemplate()
+ *
* @since 3.7.0
*/
public function display($tpl = null)
diff --git a/administrator/components/com_fields/src/View/Groups/HtmlView.php b/administrator/components/com_fields/src/View/Groups/HtmlView.php
index c6a9b2cd9de6e..107bc27b3a983 100644
--- a/administrator/components/com_fields/src/View/Groups/HtmlView.php
+++ b/administrator/components/com_fields/src/View/Groups/HtmlView.php
@@ -32,35 +32,35 @@
class HtmlView extends BaseHtmlView
{
/**
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*
* @since 3.7.0
*/
public $filterForm;
/**
- * @var array
+ * @var array
*
* @since 3.7.0
*/
public $activeFilters;
/**
- * @var array
+ * @var array
*
* @since 3.7.0
*/
protected $items;
/**
- * @var \JPagination
+ * @var \Joomla\CMS\Pagination\Pagination
*
* @since 3.7.0
*/
protected $pagination;
/**
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*
* @since 3.7.0
*/
@@ -74,6 +74,7 @@ class HtmlView extends BaseHtmlView
* @return void
*
* @see HtmlView::loadTemplate()
+ *
* @since 3.7.0
*/
public function display($tpl = null)
diff --git a/administrator/components/com_finder/src/Controller/IndexerController.php b/administrator/components/com_finder/src/Controller/IndexerController.php
index 7d557d08e840c..2852d7393cda7 100644
--- a/administrator/components/com_finder/src/Controller/IndexerController.php
+++ b/administrator/components/com_finder/src/Controller/IndexerController.php
@@ -261,9 +261,9 @@ public function optimize()
/**
* Method to handle a send a \JSON response. The body parameter
* can be an \Exception object for when an error has occurred or
- * a \JObject for a good response.
+ * a CMSObject for a good response.
*
- * @param mixed $data \JObject on success, \Exception on error. [optional]
+ * @param \Joomla\CMS\Object\CMSObject|\Exception $data CMSObject on success, \Exception on error. [optional]
*
* @return void
*
diff --git a/administrator/components/com_finder/src/Indexer/Query.php b/administrator/components/com_finder/src/Indexer/Query.php
index 5a5a652ac1cb3..952dddb0cc169 100644
--- a/administrator/components/com_finder/src/Indexer/Query.php
+++ b/administrator/components/com_finder/src/Indexer/Query.php
@@ -750,6 +750,11 @@ protected function processDates($date1, $date2, $when1, $when2)
*/
protected function processString($input, $lang, $mode)
{
+ if ($input === null)
+ {
+ $input = '';
+ }
+
// Clean up the input string.
$input = html_entity_decode($input, ENT_QUOTES, 'UTF-8');
$input = StringHelper::strtolower($input);
diff --git a/administrator/components/com_finder/src/Model/FilterModel.php b/administrator/components/com_finder/src/Model/FilterModel.php
index 7d1107305d942..a559e2e50e426 100644
--- a/administrator/components/com_finder/src/Model/FilterModel.php
+++ b/administrator/components/com_finder/src/Model/FilterModel.php
@@ -98,7 +98,7 @@ public function getFilter()
* @param array $data Data for the form. [optional]
* @param boolean $loadData True if the form is to load its own data (default case), false if not. [optional]
*
- * @return Form|boolean A \JForm object on success, false on failure
+ * @return Form|boolean A Form object on success, false on failure
*
* @since 2.5
*/
diff --git a/administrator/components/com_finder/src/Model/FiltersModel.php b/administrator/components/com_finder/src/Model/FiltersModel.php
index cd9b8f71448ff..f930fb268bde3 100644
--- a/administrator/components/com_finder/src/Model/FiltersModel.php
+++ b/administrator/components/com_finder/src/Model/FiltersModel.php
@@ -51,7 +51,7 @@ public function __construct($config = array(), MVCFactoryInterface $factory = nu
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery A \JDatabaseQuery object
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 2.5
*/
diff --git a/administrator/components/com_finder/src/Model/IndexModel.php b/administrator/components/com_finder/src/Model/IndexModel.php
index 7628988331b1f..91d5cf41a31ea 100644
--- a/administrator/components/com_finder/src/Model/IndexModel.php
+++ b/administrator/components/com_finder/src/Model/IndexModel.php
@@ -184,7 +184,7 @@ public function delete(&$pks)
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery A \JDatabaseQuery object
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 2.5
*/
@@ -331,13 +331,13 @@ public function getTotalIndexed()
}
/**
- * Returns a \JTable object, always creating it.
+ * Returns a Table object, always creating it.
*
* @param string $type The table type to instantiate. [optional]
* @param string $prefix A prefix for the table class name. [optional]
* @param array $config Configuration array for model. [optional]
*
- * @return \JTable A database object
+ * @return \Joomla\CMS\Table\Table A database object
*
* @since 2.5
*/
diff --git a/administrator/components/com_finder/src/Model/MapsModel.php b/administrator/components/com_finder/src/Model/MapsModel.php
index a3bc078d7ef72..0b53fa9bba152 100644
--- a/administrator/components/com_finder/src/Model/MapsModel.php
+++ b/administrator/components/com_finder/src/Model/MapsModel.php
@@ -165,7 +165,7 @@ public function delete(&$pks)
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery A \JDatabaseQuery object
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 2.5
*/
@@ -236,7 +236,7 @@ protected function getListQuery()
/**
* Returns a record count for the query.
*
- * @param \JDatabaseQuery|string $query The query.
+ * @param \Joomla\Database\DatabaseQuery|string
*
* @return integer Number of rows for query.
*
@@ -275,7 +275,7 @@ protected function getStoreId($id = '')
}
/**
- * Returns a \JTable object, always creating it.
+ * Returns a Table object, always creating it.
*
* @param string $type The table type to instantiate. [optional]
* @param string $prefix A prefix for the table class name. [optional]
diff --git a/administrator/components/com_finder/src/Model/SearchesModel.php b/administrator/components/com_finder/src/Model/SearchesModel.php
index e0f42310086fa..f8c83349489c5 100644
--- a/administrator/components/com_finder/src/Model/SearchesModel.php
+++ b/administrator/components/com_finder/src/Model/SearchesModel.php
@@ -94,7 +94,7 @@ protected function getStoreId($id = '')
/**
* Build an SQL query to load the list data.
*
- * @return \JDatabaseQuery
+ * @return \Joomla\Database\DatabaseQuery
*
* @since 4.0.0
*/
diff --git a/administrator/components/com_finder/src/Model/StatisticsModel.php b/administrator/components/com_finder/src/Model/StatisticsModel.php
index 53e5f67b35c6b..32b1510007328 100644
--- a/administrator/components/com_finder/src/Model/StatisticsModel.php
+++ b/administrator/components/com_finder/src/Model/StatisticsModel.php
@@ -26,7 +26,7 @@ class StatisticsModel extends BaseDatabaseModel
/**
* Method to get the component statistics
*
- * @return \JObject The component statistics
+ * @return CMSObject The component statistics
*
* @since 2.5
*/
diff --git a/administrator/components/com_finder/src/View/Filter/HtmlView.php b/administrator/components/com_finder/src/View/Filter/HtmlView.php
index a73ede3a2df5c..43dcfe64ac076 100644
--- a/administrator/components/com_finder/src/View/Filter/HtmlView.php
+++ b/administrator/components/com_finder/src/View/Filter/HtmlView.php
@@ -16,6 +16,7 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\GenericDataException;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
/**
@@ -28,15 +29,17 @@ class HtmlView extends BaseHtmlView
/**
* The filter object
*
- * @var \Joomla\Component\Finder\Administrator\Table\FilterTable
+ * @var \Joomla\Component\Finder\Administrator\Table\FilterTable
+ *
* @since 3.6.2
*/
protected $filter;
/**
- * The \JForm object
+ * The Form object
+ *
+ * @var \Joomla\CMS\Form\Form
*
- * @var \JForm
* @since 3.6.2
*/
protected $form;
@@ -44,7 +47,7 @@ class HtmlView extends BaseHtmlView
/**
* The active item
*
- * @var \JObject|boolean
+ * @var CMSObject|boolean
*
* @since 3.6.2
*/
@@ -53,7 +56,8 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var CMSObject
+ *
* @since 3.6.2
*/
protected $state;
@@ -62,6 +66,7 @@ class HtmlView extends BaseHtmlView
* The total indexed items
*
* @var integer
+ *
* @since 3.8.0
*/
protected $total;
diff --git a/administrator/components/com_finder/src/View/Filters/HtmlView.php b/administrator/components/com_finder/src/View/Filters/HtmlView.php
index 4b09bd2797895..f935a72ed948b 100644
--- a/administrator/components/com_finder/src/View/Filters/HtmlView.php
+++ b/administrator/components/com_finder/src/View/Filters/HtmlView.php
@@ -28,7 +28,7 @@ class HtmlView extends BaseHtmlView
/**
* An array of items
*
- * @var array
+ * @var array
*
* @since 3.6.1
*/
@@ -37,7 +37,7 @@ class HtmlView extends BaseHtmlView
/**
* The pagination object
*
- * @var \Joomla\CMS\Pagination\Pagination
+ * @var \Joomla\CMS\Pagination\Pagination
*
* @since 3.6.1
*/
@@ -46,7 +46,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*
* @since 3.6.1
*/
@@ -64,7 +64,8 @@ class HtmlView extends BaseHtmlView
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
@@ -73,12 +74,13 @@ class HtmlView extends BaseHtmlView
* The active search filters
*
* @var array
+ *
* @since 4.0.0
*/
public $activeFilters;
/**
- * @var boolean
+ * @var boolean
*
* @since 4.0.0
*/
diff --git a/administrator/components/com_finder/src/View/Index/HtmlView.php b/administrator/components/com_finder/src/View/Index/HtmlView.php
index 0e2e930afdbb9..fc0967692bc3a 100644
--- a/administrator/components/com_finder/src/View/Index/HtmlView.php
+++ b/administrator/components/com_finder/src/View/Index/HtmlView.php
@@ -41,7 +41,7 @@ class HtmlView extends BaseHtmlView
/**
* The pagination object
*
- * @var \Joomla\CMS\Pagination\Pagination
+ * @var \Joomla\CMS\Pagination\Pagination
*
* @since 3.6.1
*/
@@ -60,6 +60,7 @@ class HtmlView extends BaseHtmlView
* The id of the content - finder plugin in mysql
*
* @var integer
+ *
* @since 4.0.0
*/
protected $finderPluginId = 0;
@@ -67,7 +68,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var mixed
+ * @var mixed
*
* @since 3.6.1
*/
@@ -76,7 +77,7 @@ class HtmlView extends BaseHtmlView
/**
* The total number of items
*
- * @var integer
+ * @var integer
*
* @since 3.6.1
*/
@@ -85,7 +86,8 @@ class HtmlView extends BaseHtmlView
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
@@ -94,6 +96,7 @@ class HtmlView extends BaseHtmlView
* The active search filters
*
* @var array
+ *
* @since 4.0.0
*/
public $activeFilters;
diff --git a/administrator/components/com_finder/src/View/Maps/HtmlView.php b/administrator/components/com_finder/src/View/Maps/HtmlView.php
index d83eb67b5efc6..a4b9e64720066 100644
--- a/administrator/components/com_finder/src/View/Maps/HtmlView.php
+++ b/administrator/components/com_finder/src/View/Maps/HtmlView.php
@@ -38,7 +38,7 @@ class HtmlView extends BaseHtmlView
/**
* The pagination object
*
- * @var \Joomla\CMS\Pagination\Pagination
+ * @var \Joomla\CMS\Pagination\Pagination
*
* @since 3.6.1
*/
@@ -47,7 +47,7 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*
* @since 3.6.1
*/
@@ -65,7 +65,8 @@ class HtmlView extends BaseHtmlView
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
@@ -74,12 +75,13 @@ class HtmlView extends BaseHtmlView
* The active search filters
*
* @var array
+ *
* @since 4.0.0
*/
public $activeFilters;
/**
- * @var boolean
+ * @var boolean
*
* @since 4.0.0
*/
diff --git a/administrator/components/com_finder/src/View/Searches/HtmlView.php b/administrator/components/com_finder/src/View/Searches/HtmlView.php
index e10404d808ad7..b8029582de735 100644
--- a/administrator/components/com_finder/src/View/Searches/HtmlView.php
+++ b/administrator/components/com_finder/src/View/Searches/HtmlView.php
@@ -46,21 +46,22 @@ class HtmlView extends BaseHtmlView
/**
* The pagination object
*
- * @var \Joomla\CMS\Pagination\Pagination
+ * @var \Joomla\CMS\Pagination\Pagination
*/
protected $pagination;
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
@@ -69,6 +70,7 @@ class HtmlView extends BaseHtmlView
* The active search filters
*
* @var array
+ *
* @since 4.0.0
*/
public $activeFilters;
@@ -76,7 +78,8 @@ class HtmlView extends BaseHtmlView
/**
* The actions the user is authorised to perform
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
+ *
* @since 4.0.0
*/
protected $canDo;
diff --git a/administrator/components/com_finder/src/View/Statistics/HtmlView.php b/administrator/components/com_finder/src/View/Statistics/HtmlView.php
index eb37b1d7dc260..1ccaf2fce7191 100644
--- a/administrator/components/com_finder/src/View/Statistics/HtmlView.php
+++ b/administrator/components/com_finder/src/View/Statistics/HtmlView.php
@@ -24,7 +24,7 @@ class HtmlView extends BaseHtmlView
/**
* The index statistics
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*
* @since 3.6.1
*/
diff --git a/administrator/components/com_installer/src/Controller/ManageController.php b/administrator/components/com_installer/src/Controller/ManageController.php
index 3eb258e6b69e8..2dd8729627294 100644
--- a/administrator/components/com_installer/src/Controller/ManageController.php
+++ b/administrator/components/com_installer/src/Controller/ManageController.php
@@ -33,7 +33,7 @@ class ManageController extends BaseController
*
* @param array $config An optional associative array of configuration settings.
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 1.6
diff --git a/administrator/components/com_installer/src/Controller/UpdatesitesController.php b/administrator/components/com_installer/src/Controller/UpdatesitesController.php
index b9cd5b37da3a2..2c9f3d3ea736f 100644
--- a/administrator/components/com_installer/src/Controller/UpdatesitesController.php
+++ b/administrator/components/com_installer/src/Controller/UpdatesitesController.php
@@ -41,7 +41,7 @@ class UpdatesitesController extends AdminController
*
* @param array $config An optional associative array of configuration settings.
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 1.6
diff --git a/administrator/components/com_installer/src/Model/LanguagesModel.php b/administrator/components/com_installer/src/Model/LanguagesModel.php
index 1ff2457b5baa4..2e3d7b11bf0f2 100644
--- a/administrator/components/com_installer/src/Model/LanguagesModel.php
+++ b/administrator/components/com_installer/src/Model/LanguagesModel.php
@@ -207,7 +207,7 @@ function ($a, $b) use ($that)
/**
* Returns a record count for the updatesite.
*
- * @param \JDatabaseQuery|string $query The query.
+ * @param \Joomla\Database\DatabaseQuery|string $query The query.
*
* @return integer Number of rows for query.
*
diff --git a/administrator/components/com_installer/src/Model/UpdateModel.php b/administrator/components/com_installer/src/Model/UpdateModel.php
index a69c868562cf7..799779cef8079 100644
--- a/administrator/components/com_installer/src/Model/UpdateModel.php
+++ b/administrator/components/com_installer/src/Model/UpdateModel.php
@@ -14,6 +14,7 @@
use Joomla\CMS\Extension\ExtensionHelper;
use Joomla\CMS\Factory;
use Joomla\CMS\Filesystem\File;
+use Joomla\CMS\Form\Form;
use Joomla\CMS\Installer\Installer;
use Joomla\CMS\Installer\InstallerHelper;
use Joomla\CMS\Language\Text;
@@ -90,7 +91,7 @@ protected function populateState($ordering = 'u.name', $direction = 'asc')
/**
* Method to get the database query
*
- * @return \JDatabaseQuery The database query
+ * @return \Joomla\Database\DatabaseQuery The database query
*
* @since 1.6
*/
@@ -215,9 +216,9 @@ protected function translate(&$items)
/**
* Returns an object list
*
- * @param \JDatabaseQuery $query The query
- * @param int $limitstart Offset
- * @param int $limit The number of records
+ * @param DatabaseQuery $query The query
+ * @param int $limitstart Offset
+ * @param int $limit The number of records
*
* @return array
*
@@ -530,16 +531,16 @@ private function install($update)
* @param array $data Data for the form.
* @param boolean $loadData True if the form is to load its own data (default case), false if not.
*
- * @return mixed A \JForm object on success, false on failure
+ * @return Form|bool A Form object on success, false on failure
*
* @since 2.5.2
*/
public function getForm($data = array(), $loadData = true)
{
// Get the form.
- \JForm::addFormPath(JPATH_COMPONENT . '/models/forms');
- \JForm::addFieldPath(JPATH_COMPONENT . '/models/fields');
- $form = \JForm::getInstance('com_installer.update', 'update', array('load_data' => $loadData));
+ Form::addFormPath(JPATH_COMPONENT . '/models/forms');
+ Form::addFieldPath(JPATH_COMPONENT . '/models/fields');
+ $form = Form::getInstance('com_installer.update', 'update', array('load_data' => $loadData));
// Check for an error.
if ($form == false)
diff --git a/administrator/components/com_installer/src/Model/UpdatesitesModel.php b/administrator/components/com_installer/src/Model/UpdatesitesModel.php
index 1391aae10ee43..45ef7bc807ee0 100644
--- a/administrator/components/com_installer/src/Model/UpdatesitesModel.php
+++ b/administrator/components/com_installer/src/Model/UpdatesitesModel.php
@@ -12,7 +12,6 @@
\defined('_JEXEC') or die;
use Exception;
-use JDatabaseQuery;
use Joomla\CMS\Factory;
use Joomla\CMS\Filesystem\Folder;
use Joomla\CMS\Installer\Installer;
@@ -540,7 +539,7 @@ protected function getStoreId($id = '')
/**
* Method to get the database query
*
- * @return JDatabaseQuery The database query
+ * @return \Joomla\Database\DatabaseQuery The database query
*
* @since 3.4
*/
diff --git a/administrator/components/com_installer/src/View/Installer/HtmlView.php b/administrator/components/com_installer/src/View/Installer/HtmlView.php
index f2525236c1b23..bf3cbb9b938a8 100644
--- a/administrator/components/com_installer/src/View/Installer/HtmlView.php
+++ b/administrator/components/com_installer/src/View/Installer/HtmlView.php
@@ -27,7 +27,8 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
+ *
* @since 4.0.0
*/
public $state;
@@ -36,6 +37,7 @@ class HtmlView extends BaseHtmlView
* True if there are extension messages to be displayed
*
* @var boolean
+ *
* @since 4.0.0
*/
public $showMessage;
diff --git a/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php b/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php
index 5459e0412a7de..0fe702e020614 100644
--- a/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php
+++ b/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php
@@ -44,7 +44,7 @@ public function download()
try
{
- Log::add(Text::sprintf('COM_JOOMLAUPDATE_UPDATE_LOG_START', $user->id, $user->name, '' . \JVERSION), Log::INFO, 'Update');
+ Log::add(Text::sprintf('COM_JOOMLAUPDATE_UPDATE_LOG_START', $user->id, $user->name, \JVERSION), Log::INFO, 'Update');
}
catch (\RuntimeException $exception)
{
diff --git a/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php b/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
index 5424f60a846a2..bb3ef52db9b6c 100644
--- a/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
+++ b/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
@@ -80,7 +80,9 @@ public function applyUpdateSite()
}
else
{
- return Factory::getApplication()->enqueueMessage(Text::_('COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_CUSTOM_ERROR'), 'error');
+ Factory::getApplication()->enqueueMessage(Text::_('COM_JOOMLAUPDATE_CONFIG_UPDATESOURCE_CUSTOM_ERROR'), 'error');
+
+ return;
}
break;
diff --git a/administrator/components/com_joomlaupdate/src/View/Joomlaupdate/HtmlView.php b/administrator/components/com_joomlaupdate/src/View/Joomlaupdate/HtmlView.php
index 7b4fca7aa35d3..4d171af9c3512 100644
--- a/administrator/components/com_joomlaupdate/src/View/Joomlaupdate/HtmlView.php
+++ b/administrator/components/com_joomlaupdate/src/View/Joomlaupdate/HtmlView.php
@@ -64,7 +64,8 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
+ *
* @since 4.0.0
*/
protected $state;
@@ -89,7 +90,7 @@ class HtmlView extends BaseHtmlView
protected $defaultBackendTemplate = 'atum';
/**
- * Flag if the update component itself has to be updated
+ * Flag if default backend template is being used
*
* @var boolean True when default backend template is being used
*
@@ -107,7 +108,7 @@ class HtmlView extends BaseHtmlView
protected $messagePrefix = '';
/**
- * Flag if the update component itself has to be updated
+ * List of non core critical plugins
*
* @var \stdClass[]
* @since 4.0.0
diff --git a/administrator/components/com_joomlaupdate/tmpl/joomlaupdate/preupdatecheck.php b/administrator/components/com_joomlaupdate/tmpl/joomlaupdate/preupdatecheck.php
index b3624ae70cad0..68c459985f8c6 100644
--- a/administrator/components/com_joomlaupdate/tmpl/joomlaupdate/preupdatecheck.php
+++ b/administrator/components/com_joomlaupdate/tmpl/joomlaupdate/preupdatecheck.php
@@ -293,14 +293,14 @@
name; ?>
-
+ |
type)); ?>
|
version; ?>
|
- |
+ |
-
+
diff --git a/administrator/components/com_languages/src/Model/LanguageModel.php b/administrator/components/com_languages/src/Model/LanguageModel.php
index d514fd9c970b0..c9b953e22afbf 100644
--- a/administrator/components/com_languages/src/Model/LanguageModel.php
+++ b/administrator/components/com_languages/src/Model/LanguageModel.php
@@ -136,7 +136,7 @@ public function getItem($langId = null)
* @param array $data Data for the form.
* @param boolean $loadData True if the form is to load its own data (default case), false if not.
*
- * @return mixed A \JForm object on success, false on failure.
+ * @return \Joomla\CMS\Form\Form|bool A Form object on success, false on failure.
*
* @since 1.6
*/
diff --git a/administrator/components/com_languages/src/Model/OverrideModel.php b/administrator/components/com_languages/src/Model/OverrideModel.php
index 05ca9baf7ea7f..14da7729f2146 100644
--- a/administrator/components/com_languages/src/Model/OverrideModel.php
+++ b/administrator/components/com_languages/src/Model/OverrideModel.php
@@ -31,7 +31,7 @@ class OverrideModel extends AdminModel
* @param array $data Data for the form.
* @param boolean $loadData True if the form is to load its own data (default case), false if not.
*
- * @return mixed A \JForm object on success, false on failure.
+ * @return \Joomla\CMS\Form\Form|bool A Form object on success, false on failure.
*
* @since 2.5
*/
diff --git a/administrator/components/com_languages/src/View/Installed/HtmlView.php b/administrator/components/com_languages/src/View/Installed/HtmlView.php
index e391c7b24bf59..dc657fed998e5 100644
--- a/administrator/components/com_languages/src/View/Installed/HtmlView.php
+++ b/administrator/components/com_languages/src/View/Installed/HtmlView.php
@@ -49,7 +49,8 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
+ *
* @since 4.0.0
*/
protected $state;
@@ -57,7 +58,8 @@ class HtmlView extends BaseHtmlView
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
diff --git a/administrator/components/com_languages/src/View/Language/HtmlView.php b/administrator/components/com_languages/src/View/Language/HtmlView.php
index 82c30e2dca772..60abd3670b7e7 100644
--- a/administrator/components/com_languages/src/View/Language/HtmlView.php
+++ b/administrator/components/com_languages/src/View/Language/HtmlView.php
@@ -16,6 +16,7 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\GenericDataException;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
/**
@@ -33,23 +34,24 @@ class HtmlView extends BaseHtmlView
public $item;
/**
- * The \JForm object
+ * The Form object
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
public $form;
/**
* The model state
*
- * @var \JObject
+ * @var CMSObject
*/
public $state;
/**
* The actions the user is authorised to perform
*
- * @var \JObject
+ * @var CMSObject
+ *
* @since 4.0.0
*/
protected $canDo;
diff --git a/administrator/components/com_languages/src/View/Languages/HtmlView.php b/administrator/components/com_languages/src/View/Languages/HtmlView.php
index 15761430b920d..8233611961c92 100644
--- a/administrator/components/com_languages/src/View/Languages/HtmlView.php
+++ b/administrator/components/com_languages/src/View/Languages/HtmlView.php
@@ -42,7 +42,8 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
+ *
* @since 4.0.0
*/
protected $state;
@@ -50,7 +51,8 @@ class HtmlView extends BaseHtmlView
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
diff --git a/administrator/components/com_mails/src/Controller/TemplateController.php b/administrator/components/com_mails/src/Controller/TemplateController.php
index dab0b61df482f..2b980daaf07de 100644
--- a/administrator/components/com_mails/src/Controller/TemplateController.php
+++ b/administrator/components/com_mails/src/Controller/TemplateController.php
@@ -34,7 +34,7 @@ class TemplateController extends FormController
* Recognized key values include 'name', 'default_task', 'model_path', and
* 'view_path' (this list is not meant to be comprehensive).
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 4.0.0
diff --git a/administrator/components/com_mails/src/Model/TemplateModel.php b/administrator/components/com_mails/src/Model/TemplateModel.php
index ed81192e4fe48..fb5e2146e06f2 100644
--- a/administrator/components/com_mails/src/Model/TemplateModel.php
+++ b/administrator/components/com_mails/src/Model/TemplateModel.php
@@ -114,7 +114,7 @@ public function getForm($data = array(), $loadData = true)
$form->removeField('copyto', 'params');
}
- if (!trim($params->get('attachment_folder')))
+ if (!trim($params->get('attachment_folder', '')))
{
$form->removeField('attachments');
@@ -251,7 +251,7 @@ public function getMaster($pk = null)
* @param string $prefix The class prefix. Optional.
* @param array $options Configuration array for model. Optional.
*
- * @return Table A JTable object
+ * @return Table A Table object
*
* @since 4.0.0
* @throws \Exception
@@ -329,7 +329,7 @@ public function save($data)
$isNew = true;
// Include the plugins for the save events.
- \JPluginHelper::importPlugin($this->events_map['save']);
+ \Joomla\CMS\Plugin\PluginHelper::importPlugin($this->events_map['save']);
// Allow an exception to be thrown.
try
@@ -403,7 +403,7 @@ public function save($data)
/**
* Prepare and sanitise the table data prior to saving.
*
- * @param Table $table A reference to a \JTable object.
+ * @param Table $table A reference to a Table object.
*
* @return void
*
diff --git a/administrator/components/com_mails/src/View/Template/HtmlView.php b/administrator/components/com_mails/src/View/Template/HtmlView.php
index 8026506639473..8f00e96a03e24 100644
--- a/administrator/components/com_mails/src/View/Template/HtmlView.php
+++ b/administrator/components/com_mails/src/View/Template/HtmlView.php
@@ -88,7 +88,9 @@ public function display($tpl = null)
$this->templateData = array();
$language = Factory::getLanguage();
$language->load($component, JPATH_SITE, $this->item->language, true);
+ $language->load($component, JPATH_SITE . '/components/' . $component, $this->item->language, true);
$language->load($component, JPATH_ADMINISTRATOR, $this->item->language, true);
+ $language->load($component, JPATH_ADMINISTRATOR . '/components/' . $component, $this->item->language, true);
$this->master->subject = Text::_($this->master->subject);
$this->master->body = Text::_($this->master->body);
diff --git a/administrator/components/com_media/resources/scripts/store/actions.es6.js b/administrator/components/com_media/resources/scripts/store/actions.es6.js
index 965b1f45ae740..c14752396b3ec 100644
--- a/administrator/components/com_media/resources/scripts/store/actions.es6.js
+++ b/administrator/components/com_media/resources/scripts/store/actions.es6.js
@@ -3,27 +3,22 @@ import * as types from './mutation-types.es6';
import translate from '../plugins/translate.es6';
import { notifications } from '../app/Notifications.es6';
-// Actions are similar to mutations, the difference being that:
-// - Instead of mutating the state, actions commit mutations.
-// - Actions can contain arbitrary asynchronous operations.
-
-// TODO move to utils
-function updateUrlPath(path) {
- if (path == null) {
- // eslint-disable-next-line no-param-reassign
- path = '';
- }
- const url = window.location.href;
- const pattern = new RegExp('\\b(path=).*?(&|$)');
+const updateUrlPath = (path) => {
+ const currentPath = path === null ? '' : path;
+ const url = new URL(window.location.href);
- if (url.search(pattern) >= 0) {
- // eslint-disable-next-line no-restricted-globals
- history.pushState(null, '', url.replace(pattern, `$1${path}$2`));
+ if (url.searchParams.has('path')) {
+ window.history.pushState(null, '', url.href.replace(/\b(path=).*?(&|$)/, `$1${currentPath}$2`));
} else {
- // eslint-disable-next-line no-restricted-globals
- history.pushState(null, '', `${url + (url.indexOf('?') > 0 ? '&' : '?')}path=${path}`);
+ window.history.pushState(null, '', `${url.href + (url.href.indexOf('?') > 0 ? '&' : '?')}path=${currentPath}`);
}
-}
+};
+
+/**
+ * Actions are similar to mutations, the difference being that:
+ * Instead of mutating the state, actions commit mutations.
+ * Actions can contain arbitrary asynchronous operations.
+ */
/**
* Get contents of a directory from the api
diff --git a/administrator/components/com_media/resources/scripts/store/mutations.es6.js b/administrator/components/com_media/resources/scripts/store/mutations.es6.js
index 5145e89c7ca3e..f35a2316d6160 100644
--- a/administrator/components/com_media/resources/scripts/store/mutations.es6.js
+++ b/administrator/components/com_media/resources/scripts/store/mutations.es6.js
@@ -18,6 +18,7 @@ export default {
*/
[types.SELECT_DIRECTORY]: (state, payload) => {
state.selectedDirectory = payload;
+ state.search = '';
},
/**
@@ -92,9 +93,14 @@ export default {
// Update the relation to the parent directory
if (parentDirectoryIndex !== -1) {
state.directories
- .splice(parentDirectoryIndex,
+ .splice(
+ parentDirectoryIndex,
1,
- { ...parentDirectory, directories: [...parentDirectory.directories, directory.path] });
+ {
+ ...parentDirectory,
+ directories: [...parentDirectory.directories, directory.path],
+ },
+ );
}
}
@@ -119,9 +125,14 @@ export default {
// Update the relation to the parent directory
if (parentDirectoryIndex !== -1) {
state.directories
- .splice(parentDirectoryIndex,
+ .splice(
+ parentDirectoryIndex,
1,
- { ...parentDirectory, files: [...parentDirectory.files, file.path] });
+ {
+ ...parentDirectory,
+ files: [...parentDirectory.files, file.path],
+ },
+ );
}
}
@@ -158,9 +169,14 @@ export default {
state.files.push(file);
// Update the relation to the parent directory
- state.directories.splice(parentDirectoryIndex,
+ state.directories.splice(
+ parentDirectoryIndex,
1,
- { ...parentDirectory, files: [...parentDirectory.files, file.path] });
+ {
+ ...parentDirectory,
+ files: [...parentDirectory.files, file.path],
+ },
+ );
}
},
@@ -182,9 +198,14 @@ export default {
state.directories.push(directory);
// Update the relation to the parent directory
- state.directories.splice(parentDirectoryIndex,
+ state.directories.splice(
+ parentDirectoryIndex,
1,
- { ...parentDirectory, directories: [...parentDirectory.directories, directory.path] });
+ {
+ ...parentDirectory,
+ directories: [...parentDirectory.directories, directory.path],
+ },
+ );
}
},
diff --git a/administrator/components/com_media/src/Event/OAuthCallbackEvent.php b/administrator/components/com_media/src/Event/OAuthCallbackEvent.php
index b31dde792060c..d6d612c2565eb 100644
--- a/administrator/components/com_media/src/Event/OAuthCallbackEvent.php
+++ b/administrator/components/com_media/src/Event/OAuthCallbackEvent.php
@@ -25,6 +25,7 @@ class OAuthCallbackEvent extends AbstractEvent
* The event context.
*
* @var string
+ *
* @since 4.0.0
*/
private $context = null;
@@ -32,7 +33,8 @@ class OAuthCallbackEvent extends AbstractEvent
/**
* The event input.
*
- * @var \JInput
+ * @var Input
+ *
* @since 4.0.0
*/
private $input = null;
diff --git a/administrator/components/com_menus/src/Controller/ItemsController.php b/administrator/components/com_menus/src/Controller/ItemsController.php
index 15ac1f4bed305..6fc524e2b0b56 100644
--- a/administrator/components/com_menus/src/Controller/ItemsController.php
+++ b/administrator/components/com_menus/src/Controller/ItemsController.php
@@ -32,7 +32,7 @@ class ItemsController extends AdminController
*
* @param array $config An optional associative array of configuration settings.
* @param MVCFactoryInterface $factory The factory.
- * @param CMSApplication $app The JApplication for the dispatcher
+ * @param CMSApplication $app The Application for the dispatcher
* @param Input $input Input
*
* @since 1.6
diff --git a/administrator/components/com_menus/src/Helper/MenusHelper.php b/administrator/components/com_menus/src/Helper/MenusHelper.php
index 44f5767cb1fad..5afb16facba16 100644
--- a/administrator/components/com_menus/src/Helper/MenusHelper.php
+++ b/administrator/components/com_menus/src/Helper/MenusHelper.php
@@ -492,7 +492,7 @@ protected static function installPresetItems($node, $menutype)
foreach ($items as $item)
{
- /** @var \JTableMenu $table */
+ /** @var \Joomla\CMS\Table\Menu $table */
$table = Table::getInstance('Menu');
$item->alias = $menutype . '-' . $item->title;
diff --git a/administrator/components/com_menus/src/Model/ItemModel.php b/administrator/components/com_menus/src/Model/ItemModel.php
index 9812dc37e3c44..0961974acb470 100644
--- a/administrator/components/com_menus/src/Model/ItemModel.php
+++ b/administrator/components/com_menus/src/Model/ItemModel.php
@@ -756,7 +756,7 @@ public function getItem($pk = null)
// We have a valid type, inject it into the state for forms to use.
$this->setState('item.type', $table->type);
- // Convert to the \JObject before adding the params.
+ // Convert to the \Joomla\CMS\Object\CMSObject before adding the params.
$properties = $table->getProperties(1);
$result = ArrayHelper::toObject($properties);
@@ -959,7 +959,7 @@ public function getTable($type = 'Menu', $prefix = 'Administrator', $config = ar
* A protected method to get the where clause for the reorder.
* This ensures that the row will be moved relative to a row with the same menutype.
*
- * @param \JTableMenu $table instance.
+ * @param \Joomla\CMS\Table\Menu $table
*
* @return array An array of conditions to add to add to ordering queries.
*
diff --git a/administrator/components/com_menus/src/Model/MenuModel.php b/administrator/components/com_menus/src/Model/MenuModel.php
index 46bdfd3b50e98..16da0ff0479af 100644
--- a/administrator/components/com_menus/src/Model/MenuModel.php
+++ b/administrator/components/com_menus/src/Model/MenuModel.php
@@ -78,7 +78,7 @@ protected function canEditState($record)
* @param string $prefix A prefix for the table class name. Optional.
* @param array $config Configuration array for model. Optional.
*
- * @return \JTable A database object
+ * @return Table A database object
*
* @since 1.6
*/
diff --git a/administrator/components/com_menus/src/Model/MenutypesModel.php b/administrator/components/com_menus/src/Model/MenutypesModel.php
index 6011a6cf44f94..7dd30d37a0630 100644
--- a/administrator/components/com_menus/src/Model/MenutypesModel.php
+++ b/administrator/components/com_menus/src/Model/MenutypesModel.php
@@ -138,7 +138,7 @@ public function getTypeOptions()
* Method to create the reverse lookup for link-to-name.
* (can be used from onAfterGetMenuTypeOptions handlers)
*
- * @param \JObject $option with request array or string and title public variables
+ * @param CMSObject $option Object with request array or string and title public variables
*
* @return void
*
diff --git a/administrator/components/com_menus/src/Table/MenuTable.php b/administrator/components/com_menus/src/Table/MenuTable.php
index 1591f30baaad4..c0203d148920e 100644
--- a/administrator/components/com_menus/src/Table/MenuTable.php
+++ b/administrator/components/com_menus/src/Table/MenuTable.php
@@ -20,7 +20,7 @@
*
* @since 1.6
*/
-class MenuTable extends \JTableMenu
+class MenuTable extends \Joomla\CMS\Table\Menu
{
/**
* Method to delete a node and, optionally, its child nodes from the table.
diff --git a/administrator/components/com_menus/src/Table/MenuTypeTable.php b/administrator/components/com_menus/src/Table/MenuTypeTable.php
index 538d8c342875a..108656290abae 100644
--- a/administrator/components/com_menus/src/Table/MenuTypeTable.php
+++ b/administrator/components/com_menus/src/Table/MenuTypeTable.php
@@ -16,7 +16,7 @@
*
* @since 1.6
*/
-class MenuTypeTable extends \JTableMenuType
+class MenuTypeTable extends \Joomla\CMS\Table\MenuType
{
}
diff --git a/administrator/components/com_menus/src/View/Item/HtmlView.php b/administrator/components/com_menus/src/View/Item/HtmlView.php
index ddd70410e3e89..9751b0cf168a2 100644
--- a/administrator/components/com_menus/src/View/Item/HtmlView.php
+++ b/administrator/components/com_menus/src/View/Item/HtmlView.php
@@ -18,6 +18,7 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\GenericDataException;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
/**
@@ -28,16 +29,16 @@
class HtmlView extends BaseHtmlView
{
/**
- * The \JForm object
+ * The Form object
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
protected $form;
/**
* The active item
*
- * @var \JObject
+ * @var CMSObject
*/
protected $item;
@@ -49,14 +50,14 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var CMSObject
*/
protected $state;
/**
* The actions the user is authorised to perform
*
- * @var \JObject
+ * @var CMSObject
* @since 3.7.0
*/
protected $canDo;
diff --git a/administrator/components/com_menus/src/View/Items/HtmlView.php b/administrator/components/com_menus/src/View/Items/HtmlView.php
index 29090504049d9..b87698cbe2809 100644
--- a/administrator/components/com_menus/src/View/Items/HtmlView.php
+++ b/administrator/components/com_menus/src/View/Items/HtmlView.php
@@ -53,14 +53,15 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
diff --git a/administrator/components/com_menus/src/View/Menu/HtmlView.php b/administrator/components/com_menus/src/View/Menu/HtmlView.php
index 4be4f644fb3e2..4ceeff9dd6030 100644
--- a/administrator/components/com_menus/src/View/Menu/HtmlView.php
+++ b/administrator/components/com_menus/src/View/Menu/HtmlView.php
@@ -16,6 +16,7 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\MVC\View\GenericDataException;
use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
/**
@@ -26,9 +27,9 @@
class HtmlView extends BaseHtmlView
{
/**
- * The \JForm object
+ * The Form object
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
*/
protected $form;
@@ -42,14 +43,14 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var CMSObject
*/
protected $state;
/**
* The actions the user is authorised to perform
*
- * @var \JObject
+ * @var CMSObject
*/
protected $canDo;
diff --git a/administrator/components/com_menus/src/View/Menu/XmlView.php b/administrator/components/com_menus/src/View/Menu/XmlView.php
index 80107048c88b4..29b3512d85b5c 100644
--- a/administrator/components/com_menus/src/View/Menu/XmlView.php
+++ b/administrator/components/com_menus/src/View/Menu/XmlView.php
@@ -33,7 +33,7 @@ class XmlView extends BaseHtmlView
protected $items;
/**
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*
* @since 3.8.0
*/
diff --git a/administrator/components/com_menus/src/View/Menus/HtmlView.php b/administrator/components/com_menus/src/View/Menus/HtmlView.php
index 48e43ecebfd2a..e3ca25e2e3a13 100644
--- a/administrator/components/com_menus/src/View/Menus/HtmlView.php
+++ b/administrator/components/com_menus/src/View/Menus/HtmlView.php
@@ -48,14 +48,15 @@ class HtmlView extends BaseHtmlView
/**
* The model state
*
- * @var \JObject
+ * @var \Joomla\CMS\Object\CMSObject
*/
protected $state;
/**
* Form object for search filters
*
- * @var \JForm
+ * @var \Joomla\CMS\Form\Form
+ *
* @since 4.0.0
*/
public $filterForm;
diff --git a/administrator/components/com_menus/src/View/Menutypes/HtmlView.php b/administrator/components/com_menus/src/View/Menutypes/HtmlView.php
index 02337f4b208d5..5844c40e6fb82 100644
--- a/administrator/components/com_menus/src/View/Menutypes/HtmlView.php
+++ b/administrator/components/com_menus/src/View/Menutypes/HtmlView.php
@@ -36,7 +36,8 @@ class HtmlView extends BaseHtmlView
/**
* Array of menu types
*
- * @var \JObject[]
+ * @var CMSObject[]
+ *
* @since 3.7.0
*/
protected $types;
diff --git a/administrator/components/com_menus/tmpl/items/default_batch_body.php b/administrator/components/com_menus/tmpl/items/default_batch_body.php
index a329cd86e2510..acb8b8e97b71f 100644
--- a/administrator/components/com_menus/tmpl/items/default_batch_body.php
+++ b/administrator/components/com_menus/tmpl/items/default_batch_body.php
@@ -20,7 +20,7 @@
];
$published = (int) $this->state->get('filter.published');
$clientId = (int) $this->state->get('filter.client_id');
-$menuType = Factory::getApplication()->getUserState('com_menus.items.menutype');
+$menuType = Factory::getApplication()->getUserState('com_menus.items.menutype', '');
if ($clientId == 1)
{
diff --git a/administrator/components/com_menus/tmpl/items/default_batch_footer.php b/administrator/components/com_menus/tmpl/items/default_batch_footer.php
index 0216c8c0e1bfa..e58750f8d495a 100644
--- a/administrator/components/com_menus/tmpl/items/default_batch_footer.php
+++ b/administrator/components/com_menus/tmpl/items/default_batch_footer.php
@@ -13,7 +13,7 @@
$published = $this->state->get('filter.published');
$clientId = $this->state->get('filter.client_id');
-$menuType = Factory::getApplication()->getUserState('com_menus.items.menutype');
+$menuType = Factory::getApplication()->getUserState('com_menus.items.menutype', '');
?>
|