Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py, exclude 'tests' #8

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Update setup.py, exclude 'tests' #8

merged 1 commit into from
Jan 6, 2024

Conversation

onkelbeh
Copy link
Contributor

@onkelbeh onkelbeh commented Jan 4, 2024

Otherwise:

 * The following unexpected files/directories were found top-level
 * in the site-packages directory:
 *
 *   /usr/lib/python3.11/site-packages/tests
 *
 * This is most likely a bug in the build system.  More information
 * can be found in the Python Guide:
 * https://projects.gentoo.org/python/guide/qawarn.html#stray-top-level-files-in-site-packages

Otherwise:

```
 * The following unexpected files/directories were found top-level
 * in the site-packages directory:
 *
 *   /usr/lib/python3.11/site-packages/tests
 *
 * This is most likely a bug in the build system.  More information
 * can be found in the Python Guide:
 * https://projects.gentoo.org/python/guide/qawarn.html#stray-top-level-files-in-site-packages
```
@onkelbeh
Copy link
Contributor Author

onkelbeh commented Jan 4, 2024

I hope you don't mind I included your component for Home Assistant Gentoo Overlay. I do not use this component myself. But, during compilation test, the installation test script threw an error, because setup.py tries to install a package called tests at top level.

My change adds a generic exclusion to find_packages().

Thanks a lot.
\B.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7b920d) 100.00% compared to head (79ab881) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          374       374           
=========================================
  Hits           374       374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rokam rokam merged commit f976fc4 into rokam:main Jan 6, 2024
4 checks passed
@rokam
Copy link
Owner

rokam commented Jan 6, 2024

Thanks

@onkelbeh onkelbeh deleted the patch-1 branch January 6, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants