Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteUnknown behavior in rbx_xml does not respect serialization of known properties #419

Open
Dekkonot opened this issue Jun 6, 2024 · 0 comments
Labels
module: rbx_xml type: bug Something isn't working

Comments

@Dekkonot
Copy link
Member

Dekkonot commented Jun 6, 2024

When serializing using rbx_xml, one of the options is to set it to WriteUnknown properties. However, when this behavior is set, it makes properties that should not serialize start serializing if they're present on an Instance. This is most notable with UniqueId since it's automatically added by rbx_dom_weak but it could happen with other properties too.

I've tracked the behavior to this snippet:
https://github.com/rojo-rbx/rbx-dom/blob/master/rbx_xml/src/core.rs#87

This causes a property that doesn't serialize to appear as though it's unknown to the serializer. This feels unintuitive and we should probably fix it.

@Dekkonot Dekkonot added type: bug Something isn't working module: rbx_xml labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: rbx_xml type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant