Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseMount/BaseCleanMount functions are deprecated #52

Closed
FroggyFlox opened this issue May 30, 2021 · 1 comment · Fixed by #53
Closed

BaseMount/BaseCleanMount functions are deprecated #52

FroggyFlox opened this issue May 30, 2021 · 1 comment · Fixed by #53

Comments

@FroggyFlox
Copy link
Member

This issue is a follow-up of #49 .

In our config.sh, we currently use the BaseMount and BaseCleanMount. As reported in the kiwi build log, however, these functions are now deprecated as this is now taken care of by kiwi-ng itself. This deprecation happened in October 2020:
OSInside/kiwi#1597

The above methods are obsolete since kiwi handles these mount/umount processes as part of the core builder code.

It thus seems we can safely remove them from our config.sh, as has been done in Leap15.3 JeOS kiwi-template:
https://build.opensuse.org/package/view_file/openSUSE:Leap:15.3/kiwi-templates-JeOS/kiwi-templates-JeOS.changes?expand=1


Wed Sep 2 10:00:36 UTC 2020 - Fabian Vogt [email protected]

  • Drop call of baseCleanMount, not necessary

and


Wed Jan 20 14:56:24 UTC 2021 - Fabian Vogt [email protected]

  • Actually drop the call of baseCleanMount
FroggyFlox added a commit to FroggyFlox/rockstor-installer that referenced this issue May 30, 2021
phillxnet added a commit that referenced this issue Jun 1, 2021
Remove call to deprecated BaseMount/BaseCleanMount functions (#52)
@phillxnet
Copy link
Member

@FroggyFlox Thanks for your continued diligence on this one. Nice for us to stick more closely with upstream Kiwi-ng changes here, and nice to be able to remove some more kipple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants