From 25f3e856e441474cd90b042f930158415946661d Mon Sep 17 00:00:00 2001
From: FroggyFlox <flox2b@gmail.com>
Date: Fri, 15 Nov 2019 16:44:01 -0500
Subject: [PATCH] Restore service status from config backup: - Validate service
 status in config backup from name - Check the current status of the service
 and turn ON if: -- the service was ON in the backup -- the service is
 currently OFF on the new install

---
 .../storageadmin/views/config_backup.py       | 29 +++++++++++++++++--
 src/rockstor/system/config_backup.py          |  1 +
 2 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/src/rockstor/storageadmin/views/config_backup.py b/src/rockstor/storageadmin/views/config_backup.py
index d59fafd64..55bcda57a 100644
--- a/src/rockstor/storageadmin/views/config_backup.py
+++ b/src/rockstor/storageadmin/views/config_backup.py
@@ -29,6 +29,7 @@
 
 import rest_framework_custom as rfc
 from cli.rest_util import api_call
+from smart_manager.models.service import Service, ServiceStatus
 from storageadmin.models import ConfigBackup
 from storageadmin.serializers import ConfigBackupSerializer
 from storageadmin.util import handle_exception
@@ -138,15 +139,37 @@ def restore_services(ml):
         if m["model"] == "smart_manager.service":
             name = m["fields"]["name"]
             config = m["fields"]["config"]
+            pkid = m["pk"]
             if config is not None:
                 config = json.loads(config)
-                services[name] = {"config": config}
-    logger.debug("services = ({}).".format(services))
+                services[name] = {
+                    "conf": {"config": config},
+                    "id": pkid
+                }
     for s in services:
-        generic_post("%s/sm/services/%s/config" % (BASE_URL, s), services[s])
+        generic_post("{}/sm/services/{}/config".format(BASE_URL, s), services[s]["conf"])
+        # Turn the service ON if it is ON in backup AND currently OFF
+        so = Service.objects.get(name=s)
+        if validate_service_status(ml, services[s]["id"]) and not \
+                ServiceStatus.objects.get(service_id=so.id).status:
+            generic_post("{}/sm/services/{}/start".format(BASE_URL, s), {})
     logger.debug("Finished restoring services.")
 
 
+def validate_service_status(ml, pkid):
+    """
+    Parses a model list (ml) and returns True if the service identified by
+    its id (pkid) was ON in the config backup.
+    :param ml: dict of models list
+    :param pkid: int
+    :return: True
+    """
+    for m in ml:
+        if m["model"] == 'smart_manager.servicestatus' and \
+            m["fields"]["service"] is pkid:
+            return m["fields"]["status"]
+
+
 def restore_scheduled_tasks(ml):
     """
     Parses the config backup to re-create a valid POST request to be sent to the
diff --git a/src/rockstor/system/config_backup.py b/src/rockstor/system/config_backup.py
index b586c0034..99a4d5d12 100644
--- a/src/rockstor/system/config_backup.py
+++ b/src/rockstor/system/config_backup.py
@@ -42,6 +42,7 @@ def backup_config():
         ],
         "smart_manager": [
             "service",
+            "servicestatus",
             "taskdefinition"
         ],
     }