Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't this be set to 7200 to equal 24 hrs. #197

Open
htimsk opened this issue Apr 19, 2021 · 1 comment
Open

Shouldn't this be set to 7200 to equal 24 hrs. #197

htimsk opened this issue Apr 19, 2021 · 1 comment

Comments

@htimsk
Copy link

htimsk commented Apr 19, 2021

rocketpool/contracts/contract/dao/protocol/settings/RocketDAOProtocolSettingsMinipool.sol

Line 24 in a81c41c

setSettingUint("minipool.launch.timeout", 5760); // ~24 hours

If I'm understanding is the number 5760 a unit of block time. If so I recommend that this be changed to 7200 anticipating 12-second blocks post the quick merge. This would be prior to the quick merge that the dissolve time is a little longer (~26 hrs).
@kidkal
Copy link

kidkal commented Apr 24, 2021

I believe this is ETH 1 blocks, although it may need updating according to https://ycharts.com/indicators/ethereum_blocks_per_day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kidkal @htimsk