build: ensure only two minor versions (remove R 4.2.3 files) #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
changed the title
cboettig
reviewed
Aug 9, 2024
| @@ -22,7 +22,7 @@ supported_versions <- fs::dir_ls(path = "build/args", regexp = r"((\d+\.){3}json | |||
| ) |> | |||
| dplyr::slice_tail(n = 2, by = c(major, minor)) |> | |||
| dplyr::filter( | |||
| minor == dplyr::last(minor) | patch >= dplyr::lead(patch) | |||
| minor == dplyr::last(minor) | dplyr::lead(minor) == dplyr::last(minor) & patch >= dplyr::lead(patch) | |||
There was a problem hiding this comment.
nice! sorry I also overlooked this earlier!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #835
Originally intended to build only the last two minor versions (which are known to be tested in CRAN and I believe are often considered supported R versions), we actually continued to build R4.2 after the R4.4 release.
The build script has been corrected and the R4.2 files will be correctly deleted and will no longer be built.