BREAKING: repository structure change #782

eitsupi · 2024-04-21T12:54:27Z

Part of #776

…late [skip ci]

eitsupi · 2024-04-21T14:27:39Z

@cboettig Sorry for the delay, but now that we can generate at least some Dockerfiles and bakefiles, could you please take a look at this?

build/scripts/generate-args.R

build/scripts/generate-main-bakefiles.R

build/scripts/generate-main-dockerfiles.R

cboettig

I think everything here so far looks very solid!

Regarding the building last 2 versions: this all makes sense. But in this new setup is it still possible to occasionally build older versions in order to benefit from the ubuntu-lts security patches released for them?

build/scripts/generate-args.R

eitsupi · 2024-04-21T22:47:34Z

But in this new setup is it still possible to occasionally build older versions in order to benefit from the ubuntu-lts security patches released for them?

This is only possible for images that have the exact same structure as the most recent images.

For example, r-ver is fine for all versions, but rstudio cannot go back beyond a certain point because it becomes impossible to build linux/arm64 platform at some point.

eitsupi · 2024-04-22T13:36:30Z

@cboettig Do you think geospatial-ubuntugis is still needed?
I would like to remove this as I don't think any work has been done on these images in the last few years.

…e generation script [skip ci]

…generation script [skip ci]

eitsupi · 2024-04-29T13:36:16Z

Let's merging for now...

A follow up for #782

A follow up for #782 I was looking at the wiki and realized that I had forgotten to set the LANG environment variable for rocker/r-ver.

shug0131 · 2024-12-06T09:31:57Z

I forked from this repo about a year ago https://github.com/shug0131/rocker-versioned2/ . This basically adds a layer on top of rocker with extra packages, plus adds some extra libraries to allow the basic UAT to pass. But it is anchored to the old version. How would you recommend I go about merging it back with your changes to the repo structure? Would there be a way to avoid forking and making my repo copy-edit directly from the main repo ?

eitsupi · 2024-12-06T14:46:55Z

How would you recommend I go about merging it back with your changes to the repo structure? Would there be a way to avoid forking and making my repo copy-edit directly from the main repo ?

I do not understand the intent of your question.
I don't think we can adopt the changes because the previous repository structure would not be able to generate the Dockerfiles as they are now.

eitsupi requested a review from cboettig April 21, 2024 12:54

build: set devcontainer.json [skip ci]

168960f

eitsupi force-pushed the overhaul branch from 8f8af0c to 410a3b2 Compare April 21, 2024 13:32

eitsupi added 2 commits April 21, 2024 13:34

build: add variable table generate script and tables [skip ci]

263e090

build: add build args generate script and args json files [skip ci]

2cea2eb

eitsupi force-pushed the overhaul branch from 410a3b2 to 2cea2eb Compare April 21, 2024 13:34

eitsupi added 4 commits April 21, 2024 14:02

build: add Dockerfile generate script and Dockerfile templates [skip ci]

d2e311b

build: generate Dockerfiles [skip ci]

70c0ffc

build: add docker-bake.json generate script and docker-bake.json temp…

220f9f1

…late [skip ci]

build: generate docker-bake.json files [skip ci]

315913b

eitsupi added 3 commits April 21, 2024 14:28

chore: auto formatting [skip ci]

cb2c4f8

build: update files for devel images [skip ci]

bf21b61

docs: update about bakefiles generation [skip ci]

a2eb4db

eitsupi commented Apr 21, 2024

View reviewed changes

build/scripts/generate-args.R Outdated Show resolved Hide resolved

eitsupi commented Apr 21, 2024

View reviewed changes

build/scripts/generate-main-bakefiles.R Outdated Show resolved Hide resolved

build/scripts/generate-main-dockerfiles.R Outdated Show resolved Hide resolved

cboettig reviewed Apr 21, 2024

View reviewed changes

build/scripts/generate-args.R Outdated Show resolved Hide resolved

chore: update R version limit logic [skip ci]

72c1e95

eitsupi force-pushed the overhaul branch from 4b4883e to 72c1e95 Compare April 22, 2024 13:21

docs: update notes about scripts [skip ci]

d082d97

eitsupi added 6 commits April 22, 2024 14:05

build: add templates for cuda, ml, ml-verse, and update the dockerfil…

7f011ba

…e generation script [skip ci]

build: regen Dockerfiles [skip ci]

a78224d

chore: add todo comment [skip ci]

fa155ed

build: add templates for cuda docker-bake.json and update the bakefil…

35f5004

…e generation script [skip ci]

build: regen bakefiles [skip ci]

eb08179

build: add matrix for binder and cuda (latest 2 versions only) [skip ci]

4a0543b

eitsupi force-pushed the overhaul branch from e1ae53d to 4a0543b Compare April 22, 2024 14:41

build: add templates for binder Dockerfile and update the Dockerfile …

f3a47ba

…generation script [skip ci]

eitsupi force-pushed the overhaul branch from a9b2f14 to a01a960 Compare April 29, 2024 09:46

eitsupi added 16 commits April 29, 2024 10:28

build: commit args history to the tsv file (for versions in reports)

14129f2

build: update versions.Rmd for the new repo structure

74b50d2

build: fix the lack of binder target in bake-files

8881ef1

build: update wiki_home.Rmd for the new repo structure

62d98b5

ci: ensure inspect experimental images and ensure build wiki in PR

a1376cd

Merge remote-tracking branch 'upstream/master' into overhaul

8a5f5c0

ci: fix build wiki job to download experimental image info

209a4f4

ci: tweak concurrency for PRs

a3ccdfc

ci: ensure always upload the reports for checking

183265d

build(wiki): now some rows may be duplicated, so ensure remove these

aee06e2

docs(wiki): fix ordering of the table content

907c72b

ci: add a new workflow to build and push experimental images

7afda5c

docs: update for the new repo structure

57ce4c8

docs(wiki): tweak ordering of the table contents

b8df6bf

build: fix the regex to ensure remove old extra docker-bake.json

83c6959

chore: re run make setup

3d2e985

eitsupi marked this pull request as ready for review April 29, 2024 13:35

eitsupi merged commit 8417113 into master Apr 29, 2024
23 of 30 checks passed

eitsupi deleted the overhaul branch April 29, 2024 13:53

This was referenced Apr 29, 2024

Support Term? #614

Closed

fix(dockerfiles): ensure copy neccesarry scripts #796

Merged

eitsupi added a commit that referenced this pull request Apr 30, 2024

fix(dockerfiles): ensure copy neccesarry scripts (#796)

a8789c4

A follow up for #782

wetlandscapes mentioned this pull request May 1, 2024

Did repository reorganization delete a bunch of images for older versions of R? #800

Closed

eitsupi mentioned this pull request May 1, 2024

fix(dockerfile): re add the LANG environment variable #802

Merged

eitsupi added a commit that referenced this pull request May 1, 2024

fix(dockerfile): re add the LANG environment variable (#802)

4871839

A follow up for #782 I was looking at the wiki and realized that I had forgotten to set the LANG environment variable for rocker/r-ver.

infotroph mentioned this pull request Jul 22, 2024

Are 4.2.3 Dockerfiles still autogenerated? #835

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BREAKING: repository structure change #782

BREAKING: repository structure change #782

eitsupi commented Apr 21, 2024 •

edited

Loading

eitsupi commented Apr 21, 2024

cboettig left a comment

eitsupi commented Apr 21, 2024

eitsupi commented Apr 22, 2024 •

edited

Loading

eitsupi commented Apr 29, 2024

shug0131 commented Dec 6, 2024

eitsupi commented Dec 6, 2024

BREAKING: repository structure change #782

BREAKING: repository structure change #782

Conversation

eitsupi commented Apr 21, 2024 • edited Loading

eitsupi commented Apr 21, 2024

cboettig left a comment

Choose a reason for hiding this comment

eitsupi commented Apr 21, 2024

eitsupi commented Apr 22, 2024 • edited Loading

eitsupi commented Apr 29, 2024

shug0131 commented Dec 6, 2024

eitsupi commented Dec 6, 2024

eitsupi commented Apr 21, 2024 •

edited

Loading

eitsupi commented Apr 22, 2024 •

edited

Loading