Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom service account #1438

Merged
merged 2 commits into from
May 26, 2024
Merged

added custom service account #1438

merged 2 commits into from
May 26, 2024

Conversation

Avi-Robusta
Copy link
Contributor

@Avi-Robusta Avi-Robusta commented May 22, 2024

How to configure from generated_values.yaml

kubewatch:
  customServiceAccount: test-service-account
runner:
  customServiceAccount: test-service-account

Verified pods have the same origonal service account when this is not set

@Avi-Robusta Avi-Robusta marked this pull request as ready for review May 23, 2024 07:32
@Avi-Robusta Avi-Robusta changed the title added custom service account - (testing now) added custom service account May 23, 2024
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

left a minor comment

@@ -551,6 +551,7 @@ kubewatch:
readOnlyRootFilesystem: false
runAsUser: 1000
pod: {}
customServiceAccount: "" # to override the kubewatch service account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it make more sense to put in in the serviceAccount object?

seviceAccount:
  name: ""

@@ -587,6 +588,7 @@ runner:
sentry_dsn: https://[email protected]/6156573
sendAdditionalTelemetry: false
certificate: "" # base64 encoded
customServiceAccount: "" # to override the runner service account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to add it in the runnerServiceAccount object?

@arikalon1 arikalon1 merged commit d7ace4e into master May 26, 2024
14 checks passed
@arikalon1 arikalon1 deleted the custom_service_account branch May 26, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants