Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Jira Sink #1163

Closed
paoloyx opened this issue Nov 14, 2023 · 3 comments
Closed

Improve the Jira Sink #1163

paoloyx opened this issue Nov 14, 2023 · 3 comments
Labels
enhancement New feature or request sink A new sink/Problem with a sink

Comments

@paoloyx
Copy link
Contributor

paoloyx commented Nov 14, 2023

Is your feature request related to a problem?
Jira integration is very useful, albeit a bit basic in its current form. I would love Robusta to have some adding features like:

  • Closing Jira issues when a matching solved alert is fired
  • Configure Jira Sink behavior through additional params (i.e. send resolved status to Jira, re-open closed issues if new alarms arrive, etc. etc.)
  • Update existing issues with new content from Prometheus alerts (if alert's fingeprint matches)
  • Carry on additional fields coming from Prometheus alerts (i.e. runbook_url above the others)

Describe the solution you'd like
The overall flow is the one depicted here
image

In a nutshell, when a Prometheus alerts fire:

  • If there is NOT a matching Jira issue, create a new Jira issue
  • If there is a matching Jira issue that is not in DONE status, then:
    • Mark the issue is Done if alert is resolved AND Robusta is configured to send resolved status to Jira
    • Update issue summary/description if alert is not resolved
  • If there is a matching jira issue in DONE status, then:
    • If alert is resolved, there is nothing to do as Jira issue is already done
    • If alert is not resolved then:
      • If re-open issue behavior is active, re-open DONE issue
      • Create a new issue otherwise

Describe alternatives you've considered
I did not found alternatives in Robusta codebase, I was more or less used to what another project does for Prometheus (jiralert) and I'd like to implement them in Robusta

Copy link

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

  • 💬 Slack Community: Join Robusta team and other contributors on Slack here.
  • 📖 Docs: Find our documentation here.
  • 🎥 YouTube Channel: Watch our videos here.

@pavangudiwada pavangudiwada added enhancement New feature or request sink A new sink/Problem with a sink labels Nov 15, 2023
@aantn
Copy link
Collaborator

aantn commented Nov 16, 2023

This makes a lot of sense, thank you. The diagram is especially helpful.

We will review in more depth soon.

@arikalon1
Copy link
Contributor

Thanks for the PR @paoloyx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sink A new sink/Problem with a sink
Projects
None yet
Development

No branches or pull requests

4 participants