Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm] chart can't be install without defining .Values.rsa or .Values.rsa.existingSecret #1160

Closed
michMartineau opened this issue Nov 10, 2023 · 1 comment
Closed

[Helm] chart can't be install without defining .Values.rsa or .Values.rsa.existingSecret #1160

michMartineau opened this issue Nov 10, 2023 · 1 comment

Comments

@michMartineau
Copy link
Contributor

michMartineau commented Nov 10, 2023 •
edited
Loading

Describe the bug
commit 6ee8d1f introduced .Values.rsa.existingSecret.
It is not possible anymore to install the chart without defining rsa.

As .Values.rsa is nil by default, and it is a parent of existingSecret, the following change (runner.yaml) fails.

secretName: {{ default "robusta-auth-config-secret" .Values.rsa.existingSecret }}

To Reproduce
Steps to reproduce the behavior:

  • install the chart without defining .Values.rsa or .Values.rsa.existingSecret

Expected behavior
The chart should be installed without .Values.rsa or .Values.rsa.existingSecret defined

Additional context
Proposal: #1161
@pavangudiwada pavangudiwada added the needs-triage This issue should be reviewed and tagged appropriately label Nov 14, 2023
@pavangudiwada pavangudiwada removed the needs-triage This issue should be reviewed and tagged appropriately label Nov 21, 2023
@pavangudiwada
Copy link
Contributor

Closing since its merged #1161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavangudiwada @michMartineau