Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve runner service monitor in order to be useful for external prometheus #1151

Closed
michMartineau opened this issue Nov 7, 2023 · 1 comment
Closed

Improve runner service monitor in order to be useful for external prometheus #1151

michMartineau opened this issue Nov 7, 2023 · 1 comment

Comments

@michMartineau
Copy link
Contributor

Is your feature request related to a problem?
When a external embedded prometheus is used in order to scrape runner metrics, instead of the embedded one, it is not ever possible to use the service monitor defined for the runner.

Describe the solution you'd like
We would like to add additional labels on the service monitors. This labels could be needed for prometheus to see the service monitor. We would like also to add other capabilities like relabeling, metrics relabeling..

Additional context
I propose the pull request #1150
@michMartineau michMartineau changed the title Hav Improve runner service monitor in order to be useful for external prometheus Nov 7, 2023
@pavangudiwada pavangudiwada added the needs-triage This issue should be reviewed and tagged appropriately label Nov 14, 2023
@pavangudiwada
Copy link
Contributor

Thanks again! Closing based on #1150

@pavangudiwada pavangudiwada removed the needs-triage This issue should be reviewed and tagged appropriately label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavangudiwada @michMartineau