Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krr_scan pdf report does not include memory limits suggestions #1146

Closed
Disss opened this issue Nov 3, 2023 · 1 comment · Fixed by #1157
Closed

krr_scan pdf report does not include memory limits suggestions #1146

Disss opened this issue Nov 3, 2023 · 1 comment · Fixed by #1157
Assignees
@RobertSzefler
Labels
bug Something isn't working krr It's a bug effecting KRR functionality

Comments

@Disss
Copy link

Disss commented Nov 3, 2023

Describe the bug
PDF report generated by krr_scan doesn't include memory limits suggestions.

To Reproduce
Steps to reproduce the behavior:

  1. Create playbook with krr_scan action
  2. Create slack sink
  3. Trigger krr_scan
  4. Check pdf report. It won't have memory limits suggestions

Expected behavior
A pdf report should include memory limits suggestions.

Screenshots
image

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
https://github.com/robusta-dev/robusta/blob/master/playbooks/robusta_playbooks/krr.py#L170-L177
Slack discussion thread
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

  • 💬 Slack Community: Join Robusta team and other contributors on Slack here.
  • 📖 Docs: Find our documentation here.
  • 🎥 YouTube Channel: Watch our videos here.

@pavangudiwada pavangudiwada added bug Something isn't working krr It's a bug effecting KRR functionality labels Nov 8, 2023
@LeaveMyYard LeaveMyYard linked a pull request Nov 10, 2023 that will close this issue
Add resource limits to KRR reports #1157
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertSzefler RobertSzefler

Labels
bug Something isn't working krr It's a bug effecting KRR functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add resource limits to KRR reports robusta-dev/robusta
3 participants
@RobertSzefler @Disss @pavangudiwada