Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic channel on the teams sink #1083

Closed
gioppoluca opened this issue Sep 19, 2023 · 3 comments
Closed

dynamic channel on the teams sink #1083

gioppoluca opened this issue Sep 19, 2023 · 3 comments
Labels
sink A new sink/Problem with a sink

Comments

@gioppoluca
Copy link

Is your feature request related to a problem?
The need is to choose the teams where to send info dynamically without having to change anything in robusta.
Teams are associated to projects that are managed outside Robusta: the ability to read labels from Alerts (through alert relabeling) will enable Robusta to send to a sink it does not know and is not hard coded in its configurartion

Describe the solution you'd like
Solution similar to slack where sink info is red from labels/annotations

Describe alternatives you've considered
Defining CR for sink that are placed in the project NS and Robusta able to watch for these CR and configure itself to use those new CR

Additional context
Talked about this on Slack with @arikalon1

@gioppoluca
Copy link
Author

to be more specific the need is to override the existing configuration of the teams configuration:

sinksConfig:
- ms_teams_sink:
    name: dynamic_ms_teams_sink
    webhook_url: teams channel incoming webhook  # see video below

I believe that at the moment Robusta require that we define a MSTeams like the dynamic_ms_teams_sink
The need is to override the webhook_url with the value taken from the label/annotation (probably annotations should be better).
In this way we can have an existing sink configuration that robusta needs to wire its stuff but we would dynamically send to different destinations every time.

@Sheeproid Sheeproid added the sink A new sink/Problem with a sink label Oct 31, 2023
@aantn
Copy link
Collaborator

aantn commented Nov 6, 2023

Hey, any interest in working on a PR for this? It should be possible to copy some of the code from the Slack sink.

@RoiGlinik
Copy link
Contributor

@gioppoluca This will be available in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink A new sink/Problem with a sink
Projects
None yet
Development

No branches or pull requests

4 participants