Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup use of virtualAnalogRemapper device #197

Open
traversaro opened this issue Nov 18, 2024 · 0 comments
Open

Cleanup use of virtualAnalogRemapper device #197

traversaro opened this issue Nov 18, 2024 · 0 comments

Comments

@traversaro
Copy link
Member

Currently wholebodydynamics uses the VirtualAnalogRemapper device to publish the torque estimates. This is necessary as the controlBoardRemapper does not supports out of the box the IVirtualAnalogSensors interfaces.

The reason for this is historical. While embObjMotionControl implement IVirtualAnalogSensors, and so there the IVirtualAnalogSensors basically acts as any other controlboard interfaces, back in pure-CAN iCub robots, the IVirtualAnalogSensors interface was not implemented by CanBusMotionControl, but rather a different device called CanBusVirtualAnalogSensors, so it was not possible to use the same remapper for both controlboardinterfaces and virtualanalogsensors. Now that support for CAN-based robots have been dropped, I think the cleanest solution is just to add support for IVirtualAnalogSensors interface to controlboardremapper, and call it a day.

This is important as in blf @isorrentino is using the virtualAnalogRemapper device in https://github.com/ami-iit/bipedal-locomotion-framework/blob/78bae85d6b39f20633a669a951f12acb482df127/devices/RobotDynamicsEstimatorDevice/src/RobotDynamicsEstimatorDevice.cpp#L535-L565 , but then it was passing to it just normal controlBoardRemapper, and it was confused as it was not working.

fyi @GiulioRomualdi @LoreMoretti

@traversaro traversaro changed the title Cleanup use of VirtualAnalogRemapper device Cleanup use of virtualAnalogRemapper device Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant