You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently wholebodydynamics uses the VirtualAnalogRemapper device to publish the torque estimates. This is necessary as the controlBoardRemapper does not supports out of the box the IVirtualAnalogSensors interfaces.
The reason for this is historical. While embObjMotionControl implement IVirtualAnalogSensors, and so there the IVirtualAnalogSensors basically acts as any other controlboard interfaces, back in pure-CAN iCub robots, the IVirtualAnalogSensors interface was not implemented by CanBusMotionControl, but rather a different device called CanBusVirtualAnalogSensors, so it was not possible to use the same remapper for both controlboardinterfaces and virtualanalogsensors. Now that support for CAN-based robots have been dropped, I think the cleanest solution is just to add support for IVirtualAnalogSensors interface to controlboardremapper, and call it a day.
Currently
wholebodydynamics
uses theVirtualAnalogRemapper
device to publish the torque estimates. This is necessary as thecontrolBoardRemapper
does not supports out of the box theIVirtualAnalogSensors
interfaces.The reason for this is historical. While
embObjMotionControl
implementIVirtualAnalogSensors
, and so there theIVirtualAnalogSensors
basically acts as any other controlboard interfaces, back in pure-CAN iCub robots, theIVirtualAnalogSensors
interface was not implemented byCanBusMotionControl
, but rather a different device calledCanBusVirtualAnalogSensors
, so it was not possible to use the same remapper for both controlboardinterfaces and virtualanalogsensors. Now that support for CAN-based robots have been dropped, I think the cleanest solution is just to add support forIVirtualAnalogSensors
interface tocontrolboardremapper
, and call it a day.This is important as in blf @isorrentino is using the
virtualAnalogRemapper
device in https://github.com/ami-iit/bipedal-locomotion-framework/blob/78bae85d6b39f20633a669a951f12acb482df127/devices/RobotDynamicsEstimatorDevice/src/RobotDynamicsEstimatorDevice.cpp#L535-L565 , but then it was passing to it just normalcontrolBoardRemapper
, and it was confused as it was not working.fyi @GiulioRomualdi @LoreMoretti
The text was updated successfully, but these errors were encountered: