Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the components of the toolbox #83

Closed
diegoferigo opened this issue Feb 24, 2018 · 1 comment
Closed

Split the components of the toolbox #83

diegoferigo opened this issue Feb 24, 2018 · 1 comment
Assignees
@diegoferigo
Labels
complexity::medium component::blocks issue::resolution::fixed priority::normal type::enhancement
Milestone
Automatic Code Ge...

Comments

@diegoferigo
Copy link
Member

Until the 3.0 version, the toolbox installs a monolithic mex function generated by linking all the blocks with the toolbox utilities (BlockInformation, RobotInterface, Configuration, Log, ...) and the toolbox.cpp S-function.

Considering the experimental automatic code generation support #82, generating different components by splitting the library in the following way might be helfulp:

  • WBToolboxLibrary: all the classes for having Blocks and WB-Blocks fully functioning
  • WBToolbox.mex: the WBToolboxLibrary plus simulink-related stuff (SimulinkBlockInformation, toolbox.cpp, and Matlab's libraries)
  • WBToolboxCoder: the WBToolboxLibrary plus simulink-coder-related stuff (Other issues)

In this way, the WBToolboxLibrary becomes a real shared library that is compiled against either simulink libraries (and this would require Matlab installed) or the driver of the generated code (Matlab-independent).
@diegoferigo diegoferigo self-assigned this Feb 24, 2018
@diegoferigo diegoferigo added this to the Automatic Code Generation milestone Feb 24, 2018
diegoferigo added a commit to diegoferigo/WB-Toolbox that referenced this issue Apr 4, 2018
@diegoferigo
Split toolbox components (library, simulink, coder)
117d915 
Fix robotology#83
Fix robotology#44
diegoferigo added a commit to diegoferigo/WB-Toolbox that referenced this issue May 7, 2018
@diegoferigo
Split toolbox components (library, simulink, coder)
47a920c 
Fix robotology#83
Fix robotology#44
@diegoferigo
Copy link
Member Author

diegoferigo commented May 8, 2018 •
edited
Loading

Fixed by 47a920c.

@diegoferigo diegoferigo mentioned this issue Jun 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegoferigo diegoferigo

Labels
complexity::medium component::blocks issue::resolution::fixed priority::normal type::enhancement
Projects
None yet
Milestone
Automatic Code Generation
Development

No branches or pull requests
1 participant
@diegoferigo