-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable manifpy compilation when ROBOTOLOGY_USES_PYTHON is enabled #799
Comments
Sister issue: conda-forge/manif-feedstock#3 . |
I'm not really an expert of packaging for conda. If I understood correctly, instead of getting files from the CMake install tree as we do for other projects, we have to pass through setuptools that will install the Python files in the enabled site-packages, and then package this folder with conda. Correct? If this is ok in the conda-side, it seems to be the easiest solution at the moment. Note that I recently opened artivis/manif#228 that, depending if and how it will get implemented, could involve a new CMake machinery similar to what we are are used to have in our hybrid projects. |
To clarify, the issue on manifpy packaging in conda is conda-forge/manif-feedstock#3 . This one is to install manifpy as part of the robotology-superbuild. |
Calling a setup.py from the |
Maybe we can wait artivis/manif#233? However, this means that we cannot support the newly tagged release. |
Cool, I did not saw that! This is not a big problem, if the PR is not merged soon I can quickly create a internal release on a fork and use that one, the proper release was just necessary for conda-forge. |
Differently from most C++/Python projects that we support,
manif
does not permit to install from CMake its Python bindings (see https://github.com/artivis/manif/blob/0.0.4/python/CMakeLists.txt, and do not get afraid for theEIGEN_DEFAULT_TO_ROW_MAJOR
as I was : ) ). Instead, the "installation" is happening in thesetup.py
by setting theCMAKE_LIBRARY_OUTPUT_DIRECTORY
variable to the desired installation location.So the options are:
Any opinion @GiulioRomualdi @diegoferigo ?
The text was updated successfully, but these errors were encountered: