-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive from concrete YARP classes instead of providing custom implementation #162
Comments
Blocking #171 |
Note to self: take a look at http://www.yarp.it/classyarp_1_1dev_1_1ControlBoardHelper.html (perhaps for internal use only). |
Does not really block #171 |
This WIP led to robotology/yarp#1867, another PR is coming. |
Blocks #171. |
Might render invalid due to #211. |
For instance, if we take a look at ImplementControlLimits.h, there are two interfaces:
The |
YARP's fakeMotionControl device inherits from several
ImplementX
concrete classes, e.g.ImplementVelocityControl2
, a ready-to-use implementation ofIVelocityControl2
. See inheritance diagram in fakeMotionControl's docs. I wonder if we could use this in our CAN devices to spare a few lines of code.The text was updated successfully, but these errors were encountered: