Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read current speed and acceleration values from TechnosoftIpos device via CAN #121

Closed
PeterBowman opened this issue May 10, 2017 · 4 comments
Assignees

Comments

@PeterBowman
Copy link
Member

PeterBowman commented May 10, 2017

Currently, commanded speeds and accelerations get stored in their respective member fields, TechnosoftIpos::refSpeed and TechnosoftIpos::refAcceleration, upon each set-like function call (involving thread locks): example. It would be preferable to pull the current value from the driver instead of evaluating said fields: click/ref.

@PeterBowman
Copy link
Member Author

Rebased on develop and WIP at b076348, now I have to apply #119/#144 and run some tests (again).

@PeterBowman
Copy link
Member Author

Done at ef0fad9, tested on ASIBOT.

@PeterBowman
Copy link
Member Author

Just for clarification, now we may pull from the driver:

  • actual reference speeds and accelerations (position mode)
  • current velocity (velocity mode)

Don't be scared when you'll see lots of decimals instead of fixed integers (e.g. 4.9999 instead of 5).

@jgvictores
Copy link
Member

Great!

Thanks to this, I also reviewed the code and started #153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants