Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPy Type Checking in CI #17

Open
nigelmj opened this issue May 20, 2024 · 2 comments
Open

MyPy Type Checking in CI #17

nigelmj opened this issue May 20, 2024 · 2 comments

Comments

@nigelmj
Copy link
Contributor

nigelmj commented May 20, 2024

Add static type checking to the ci pipeline using MyPy. Since the codebase already utilises the typing module, it would be useful to ensure type safety by integrating Mypy checks. Improvement to Ref #12 .

@nigelmj
Copy link
Contributor Author

nigelmj commented May 20, 2024

@suzanneEmbury As this issue is mainly an incremental improvement to the CI pipeline workflow, I can wait until the previous PR addressing Ref #12 has been merged before I create a new PR. If you would instead prefer a separate file for type checking I can create a PR by the end of this week.

@suzanneEmbury
Copy link
Contributor

Just in case @nigelmj or anyone is interested in picking up this suggested change, PR #12 has been merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants