Promise.isDispatched now exposed as read-only property #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2017 12:29
It's sometimes necessary, or at least useful to check whether a promise signal has already been dispatched.
Promise.isDispatched now exposed as read-only var
esidegallery
changed the title
…hing when dispatching more than once.
src/org/osflash/signals/Promise.as
Outdated
| @@ -50,7 +53,10 @@ package org.osflash.signals | |||
| { | |||
| if (_isDispatched) | |||
| { | |||
| throw new IllegalOperationError("You cannot dispatch() a Promise more than once"); | |||
| if (!ignoreSubsequentDipatches) | |||
There was a problem hiding this comment.
Why not just use a OnceSignal?
There was a problem hiding this comment.
I wasn't aware I was submitting this as a pull request! I'm using promises for their retroactive dispatch functionality, and was sometimes getting runtime errors as promises sometimes got dispatched more than once. This just got around that issue.
Promise now implements IPriorityOnceSignal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes necessary, or at least useful to check whether a promise signal has already been dispatched.