Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Parameter Bugs: potet, soil_moist_max, soil_rechr_max #2

Open
rsregan opened this issue Sep 9, 2019 · 1 comment
Open

Dynamic Parameter Bugs: potet, soil_moist_max, soil_rechr_max #2

rsregan opened this issue Sep 9, 2019 · 1 comment

Comments

@rsregan
Copy link
Collaborator

rsregan commented Sep 9, 2019

No description provided.

@rsregan
Copy link
Collaborator Author

rsregan commented Sep 9, 2019

potet coefficients were being set each time step instead of only when new values were read, so values set to super small values.

Similar issue if dynamic soil_moist_max or soil_rechr_max, but, it was just checking values each time step instead of updating to bad values, so just extra CPU burning.

Fixes made in dynamic_param_read.f90

rniswon pushed a commit that referenced this issue Mar 24, 2020
@jlarsen-usgs
Merge pull request #2 from rniswon/master
ef29d15 
Upsteam merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsregan