You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.
Very good project, indeed.
However I took a look on some code and what I don't understand why there are includes of <Arduino.h> in many files. For example in "pc_comm.h" it includes <Arduino.h>, the same in "due_can.h"
In my opinion, your project is more valuable than Macchina project, so it would be better to make such structure, that if you would like to port it on different platform, then you rewrite just a small part that is tied to Arduino IDE and Macchina, so better not to mix everything up. Or please add a comment, which statements use those includes.
The text was updated successfully, but these errors were encountered:
Very good project, indeed.
However I took a look on some code and what I don't understand why there are includes of <Arduino.h> in many files. For example in "pc_comm.h" it includes <Arduino.h>, the same in "due_can.h"
In my opinion, your project is more valuable than Macchina project, so it would be better to make such structure, that if you would like to port it on different platform, then you rewrite just a small part that is tied to Arduino IDE and Macchina, so better not to mix everything up. Or please add a comment, which statements use those includes.
The text was updated successfully, but these errors were encountered: