Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Congratulations #2

Open
MarkoBursic opened this issue Nov 5, 2020 · 1 comment
Open

Congratulations #2

MarkoBursic opened this issue Nov 5, 2020 · 1 comment

Comments

@MarkoBursic
Copy link

Very good project, indeed.
However I took a look on some code and what I don't understand why there are includes of <Arduino.h> in many files. For example in "pc_comm.h" it includes <Arduino.h>, the same in "due_can.h"
In my opinion, your project is more valuable than Macchina project, so it would be better to make such structure, that if you would like to port it on different platform, then you rewrite just a small part that is tied to Arduino IDE and Macchina, so better not to mix everything up. Or please add a comment, which statements use those includes.

@autoprog
Copy link

hi,

set Arduino platform manege library
creat file def.h to pins...

#ifndef MYDEF_H_
#define MYDEF_H_
#include <stdint.h>
#include <Arduino.h>
#define L1 73

#define L2 72

#define DS7_GREEN 73
#define DS7_BLUE 72
#define DS7_RED 72
#define DS6 0
#define DS5 0
#define DS4 0
#define DS3 0
#define DS2 0
#endif
//---------------
error in due_can.cpp
// rxframe->time = (ul_status & CAN_MSR_MTIMESTAMP_Msk); <-----

done, compiling ok

thanks,
Carlos.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants