Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIP-0017 Remove theme from on-chain, move it to metadata spec #64

Open
Yuripetusko opened this issue Jan 16, 2023 · 0 comments
Open

RIP-0017 Remove theme from on-chain, move it to metadata spec #64

Yuripetusko opened this issue Jan 16, 2023 · 0 comments
Labels
RIP RMRK Improvement Proposal

Comments

@Yuripetusko
Copy link
Member

  • author(s): Yuri Petusko
  • contact: @Yuripetusko
  • RIP type: upgrade

RIP Summary

We shouldn't be saving theme object on-chain and instead adding it as a property to add to metadata and saved on IPFS

RIP Details

There's no point, and often not possible (like on evm/substrate) to save theme object arbitrary shape on-chain, we should instead add it as optional property to save alongside other metadata properties and write a guide for consumers/clients on how to parse and use with different base types, starting with SVG base (catalog).

Examples

const metadataFields: Metadata = {
  mediaUri: 'ipfs://ipfs/xxx',
  externalUri: 'https://singular.app',
  name: 'Rare #333,
  description: 'Very rare bird',
  theme: {theme_color_1: '#dd6195', theme_color_2: '#fdb453', theme_color_3: '#370842', theme_color_4: '#8f2386'}
};

Open Questions

Questions for the community, to still be discussed.

Prior work (optional)

Citations, acknowledgments for inspiration, projects this RIP is emulating, etc.

Impact

We don't have many existing NFTs which use theme so this shouldn't impact many

@Yuripetusko Yuripetusko added the RIP RMRK Improvement Proposal label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RIP RMRK Improvement Proposal
Projects
None yet
Development

No branches or pull requests

1 participant