Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect traits/skills & some suggestions #18

Open
char6s opened this issue May 22, 2020 · 16 comments
Open

Incorrect traits/skills & some suggestions #18

char6s opened this issue May 22, 2020 · 16 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@char6s
Copy link

char6s commented May 22, 2020

Buffed:

  • chance to not recoil
  • chance to prevent vernier consumption when stepping
  • chance of attacks penetrating super armor

Incorrect:

  • Tallgeese II head & Build Mk-II arms (alpha is self buff not squad)
  • Geara Doga arms (armor < 30%, reduce melee dmg taken 15 not increase ex skill power)
  • Bolt & Master torso (matk buff is 29%, mdef is 19%, no satk buff)

Suggestions:

  • Ex skill stats
  • Separate melee power & strong melee power
  • Build according to look
  • Button for instantly gold mark all
  • Filter: weapon category, jobs, ex skill power, limited/regular/event suits
  • Sort: rarity
  • CPWR calc

Good work with the calculator! 👍

@rmkane
Copy link
Owner

rmkane commented May 24, 2020

Sounds good, thanks.

I am still cleaning up the traits... just pushed out version 1.1.8 which was a MAJOR overhaul to the text. I will now focus on some of these, I will try to address most of them.

@rmkane rmkane added this to the 1.1.9 milestone May 24, 2020
@rmkane rmkane added the bug Something isn't working label May 24, 2020
@rmkane
Copy link
Owner

rmkane commented May 24, 2020

Not sure what "buffed" means, I assume you mean, "please add?"

I actually added them in the last patch.

https://github.com/rmkane/gbgwcalculator.github.io/blob/master/data/json/traits.json

There is also this trait: ""Recover X Armor gradually"", but the calculator cannot search partial phrases and it is not set-up for regular expressions. I will try to see if I can address this is the most efficient way possible.

@rmkane
Copy link
Owner

rmkane commented May 24, 2020

I am gonna push these out as a hotpatch.

Incorrect:

  • Tallgeese II head & Build Mk-II arms (alpha is self buff not squad)
  • Geara Doga arms (armor < 30%, reduce melee dmg taken 15 not increase ex skill power)
  • Bolt & Master torso (matk buff is 29%, mdef is 19%, no satk buff)

I also fixed Sai Saichi's trait text...


Edit: Alright, I fixed these in: #19

@rmkane
Copy link
Owner

rmkane commented May 24, 2020

Ex skill stats

Yes, I am in the process of implementing this.

Separate melee power & strong melee power

I will try my best

Build according to look

This would be based on the unit ID, but I do not send that over, because the original author did not organize the data by unit like I have... I want this too and have been thinking about how to implement it efficiently.

Button for instantly gold mark all

Sounds reasonable.

Filter: weapon category, jobs, ex skill power, limited/regular/event suits

This is all data that I have, but am not sending it over, because the calculator does not support it at this time. I really need to sync the calculator to my database...

Sort: rarity

Sounds easy enough.

CPWR calc

I am not sure what the formula is? Could you provide a reference to one?

@rmkane rmkane added the enhancement New feature or request label May 24, 2020
@char6s
Copy link
Author

char6s commented May 24, 2020

Not sure what "buffed" means, I assume you mean, "please add?"

The min/max values for those traits were buffed in 1.4 but only for 3* parts & above. For example, Duo's 20% chance to not recoil is now 33%.

I am not sure what the formula is? Could you provide a reference to one?

Sorry don't have one but it's alright if you can't add it since CPWR is not really important.

@rmkane
Copy link
Owner

rmkane commented May 24, 2020

I will take a look at the "new" stats. I only ever "add" new entries. Unless I am aware there was a change, the stats remain the same. Maybe I can use Dengeki, if they have a way... so I can quickly compare.


I see it now…

696755A9-1A00-42CB-ADF6-BB71C6F1BD46

@rmkane
Copy link
Owner

rmkane commented May 24, 2020

I am gonna try writing a userscript that parses a Degeki page to spit out the stats for the parts and weapons, so I can quickly compare with what I have... it will take a bit of time... something I have been meaning to do anyways.


Edit: It is done (sort of), the script can be found here: https://gist.github.com/rmkane/1990061bdcd7f8d59a39e413a7b4f050#file-ver-1-2-0-userscript-js

I am gonna integrate the code into this project under a userscripts directory.

@rmkane
Copy link
Owner

rmkane commented May 25, 2020

Alright, I updated the traits: #21

Here are the queries I ran, to find them:

select `id`, `name`, `trait` from `pilot` where lower(`trait`) like '%chance to not recoil%' order by `name` asc;

select `id`, `name`, `trait` from `pilot` where lower(`trait`) like '%chance to prevent vernier consumption when stepping%' order by `name` asc;

select `id`, `name`, `trait` from `pilot` where lower(`trait`) like '%chance of attacks penetrating super armor%' order by `name` asc;

select p.id, p.name, pt.name, p.trait from `part` p, `part_type` pt where pt.id = p.part_type_id and lower(p.trait) like '%chance to not recoil%' order by p.name asc;

select p.id, p.name, pt.name, p.trait from `part` p, `part_type` pt where pt.id = p.part_type_id and lower(p.trait) like '%chance to prevent vernier consumption when stepping%' order by p.name asc;

select p.id, p.rarity, p.name, pt.name, p.trait from `part` p, `part_type` pt where pt.id = p.part_type_id and lower(p.trait) like '%chance of attacks penetrating super armor%' order by p.rarity, p.name asc;

@Hyperaiser
Copy link

Hey man, i wanna ask you about the GBGW calculator.
I was in charge with the origin creator of GBGW calculator, then i couldnt contact to him from Asia Newyear, and he modified his codes before. If you can make it far like this, you must know him - the very first creator owner, do you?
Anyway, your did your job very well.

@rmkane
Copy link
Owner

rmkane commented May 28, 2020

@Hyperaiser I do not know the original creator. I reverse-engineered the code.

I took the liberty of forking it and turning it into a manageable application.

@char6s
Copy link
Author

char6s commented May 28, 2020

  • Block Hack β reduces Melee Defense of all enemies not heal allies
  • Geara Doga torso current trait should be on the arms. The correct torso trait is When Armor is 30% or less, Buff EX Skill effect up 12%

@rmkane
Copy link
Owner

rmkane commented Jun 4, 2020

  • Block Hack β reduces Melee Defense of all enemies not heal allies

  • Geara Doga torso current trait should be on the arms. The correct torso trait is When Armor is 30% or less, Buff EX Skill effect up 12%

I will take care of these very soon. Thanks.

@rmkane
Copy link
Owner

rmkane commented Jun 30, 2020

Still want to do these:

  • Build according to look
  • Button for instantly gold mark all
  • Filter: weapon category, jobs, ex skill power, limited/regular/event suits

But I would probably re-write the website for the 2.0 update and incorporate these as foundational features.

@Hyperaiser
Copy link

Hyperaiser commented Jul 5, 2020

@Hyperaiser I do not know the original creator. I reverse-engineered the code.

I took the liberty of forking it and turning it into a manageable application.

Since he did it wholeheartedly for GBGW community, but i feel it a little bit since he got suprise when he saw your calculator and asked who made it.
So, do you plan to use this calculator for commercial purpose?

@rmkane
Copy link
Owner

rmkane commented Jul 13, 2020

@Hyperaiser Nope...

It's just a hobby.

@Hyperaiser
Copy link

Hyperaiser commented Jul 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants