-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load sourceline information for global variables #4635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbillow
requested review from
ret2libc,
wargio,
XVilka,
kazarmy and
thestr4ng3r
as code owners
September 14, 2024 10:55
XVilka
requested changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test using that binary I attached to the issue.
XVilka
requested changes
Sep 14, 2024
imbillow
force-pushed
the
var-global-source
branch
from
September 14, 2024 12:56
8aa770d
to
2b95de8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
imbillow
force-pushed
the
var-global-source
branch
from
September 14, 2024 14:52
dc0d968
to
688de7d
Compare
XVilka
reviewed
Sep 14, 2024
XVilka
approved these changes
Sep 14, 2024
XVilka
reviewed
Sep 14, 2024
This comment was marked as resolved.
This comment was marked as resolved.
On Windows:
|
imbillow
force-pushed
the
var-global-source
branch
from
September 15, 2024 16:04
cd24a1f
to
75a989d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQUASH ME
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
closes #4619