Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace strdup with rz_str_dup #4634

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Replace strdup with rz_str_dup #4634

merged 2 commits into from
Sep 15, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Sep 13, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Replaces all the calls to strdup to rz_str_dup

Fix #4633 but does not fix the actual cause.

karliss
karliss requested changes Sep 13, 2024
View reviewed changes
librz/arch/types/functions-libc.sdb.txt Outdated Show resolved Hide resolved
@wargio wargio requested a review from karliss September 14, 2024 02:15
@wargio wargio merged commit db1e499 into dev Sep 15, 2024
20 of 24 checks passed
@wargio wargio deleted the remove-unsafe-strdup branch September 15, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@XVilka XVilka Awaiting requested review from XVilka XVilka is a code owner

@yossizap yossizap Awaiting requested review from yossizap yossizap is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@karliss karliss Awaiting requested review from karliss

Assignees
No one assigned
Labels
8051 ARM AVR BSD DEX dietline DWARF ELF ESIL GDB java LUA Mach-O macOS MIPS panel PDB PE PIC PPC PYC rizin rz-asm rz-ax rz-bin rz-diff rz-find rz-gg rz-hash RzAnalysis RzAsm-Assembler RzAsm-Disassembler RzBin RzBreakpoint RzConfig RzCons RzCore RzDebug RzEgg RzFlag RzHash RZIL RzIO RzLang RzParse RzReg RzSocket RzSyscall RzType RzUtil SH TMS320 visual WinDbg Windows X86
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault while loading PDB
2 participants
@wargio @karliss