Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binutils code to the latest binutils #814

Open
7 of 12 tasks
XVilka opened this issue Mar 12, 2021 · 4 comments
Open
7 of 12 tasks

Update binutils code to the latest binutils #814

XVilka opened this issue Mar 12, 2021 · 4 comments
Labels
disassembly good first issue Good for newcomers help wanted Extra attention is needed refactor Refactoring requests SPARC
Milestone

Comments

@XVilka
Copy link
Member

XVilka commented Mar 12, 2021

Until we figured how to reuse the code using linking or Meson subprojects, it's better to update the binutils code in Rizin to support more instructions. The current code is very old.

Pieces from binutils-gdb were used in many different places (opcodes library/libopcodes, libiberty, BFD library):

Please be careful, since some of these copied sources could have custom modifications after they were imported - I recommend to check the git history of Rizin and Radare2 to see them. Good example how to do that is in a similar issue for libmagic: #721

See also #2704

@XVilka XVilka added good first issue Good for newcomers help wanted Extra attention is needed refactor Refactoring requests disassembly labels Mar 12, 2021
@XVilka

This comment was marked as outdated.

@officialcjunior
Copy link
Member

I was trying to update hppa/gnu. It compiles fine, but they seem to have changed their format a bit and removed braces for if statements with one lines, making a huge diff at some places. Should I do anything with that?

@ret2libc
Copy link
Member

IMHO the code should be taken as-is from upstream and moved to a subproject. If necessary (it is necessary likely) we will provide a custom meson.build as done for others subprojects to create a meson object that compiles the right files with the right config.

@ret2libc
Copy link
Member

i don't expect much work to happen here any time soon. Also, as I will refactor plugins hopefully immediately after 0.4.0, it would be better to have the dependency to binutils limited to those plugins.

@stale stale bot added the stale label Jul 19, 2022
@stale stale bot closed this as completed Sep 17, 2022
@XVilka XVilka reopened this Sep 17, 2022
@stale stale bot removed the stale label Sep 17, 2022
@XVilka XVilka added this to the 0.6.0 milestone Sep 19, 2022
@rizinorg rizinorg deleted a comment from stale bot Oct 12, 2022
@rizinorg rizinorg deleted a comment from stale bot Oct 12, 2022
@rizinorg rizinorg deleted a comment from stale bot May 16, 2023
@XVilka XVilka modified the milestones: 0.6.0, 0.7.0 Jun 9, 2023
@XVilka XVilka modified the milestones: 0.7.0, 0.8.0 Feb 10, 2024
@XVilka XVilka added the SPARC label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disassembly good first issue Good for newcomers help wanted Extra attention is needed refactor Refactoring requests SPARC
Projects
None yet
Development

No branches or pull requests

3 participants